This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
0x-sra-client.py: Fix bug in config_order, and other small improvements #2399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Root problem is that there are too many backslashes in the SRA spec itself. See #1727 This was previously fixed for heavily-tested endpoints (get and post order, etc), but was only recently discovered for the get-order-config endpoint.
feuGeneA
force-pushed
the
python/sra-client-config-order-fix
branch
from
ee8fc3f to
a4bd546
Compare
feuGeneA
changed the title
|
PirosB3
reviewed
Dec 19, 2019
| print("Removing src/zero_ex/contract_wrappers/*/__init__.py...") | ||
| for contract in glob( | ||
| path.join( | ||
| ".", "src", "zero_ex", "contract_wrappers", "*", "__init__.py" |
There was a problem hiding this comment.
small nit here - this path is relative to the directory the current process is in, and not relative to the directory the current file is in. I think you want the latter?
Example
If I ran..
cd /tmp/
python path/to/monorepo/python-packages/contract_wrappers/setup.py
LOC 114 would result in /tmp/src/zero_ex/contract_wrappers/*/__init__.py while I think you wanted it to be /tmp/path/to/monorepo/python-packages/contract_wrappers/src/zero_ex/contract_wrappers/*/__init__.py
There was a problem hiding this comment.
You're absolutely right on this... but I don't think it's worth accommodating at this point. The script already generally lacks support for this type of interaction.
|
@feuGeneA the more I try out this code, the more I feel that Is there any way that the current |
|
Aside from this, you code works great. I tested it using: >>> relayer = RelayerApi('https://v3.kovan.backend.sra.0x.org')
>>> order_config = relayer.get_order_config(relayer_api_order_config_payload_schema=my_order)
>>> print(order_config)
{'fee_recipient_address': '0x0000000000000000000000000000000000000000',
'maker_fee': '0',
'sender_address': '0x0000000000000000000000000000000000000000',
'taker_fee': '0'} |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2385
See generated docs at https://104044-92181371-gh.circle-artifacts.com/0/root/repo/python-packages/sra_client/build/docs/html/index.html
Type of changes: