This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
Swallow reverts in ERC20BridgeSampler #2395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dorothy-zbornak
force-pushed
the
feat/contracts/erc20-bridge-sampler/graceful-reverts
branch
from
6e3e7a8 to
7737a9c
Compare
…ow revets on DEX quotes.
dorothy-zbornak
force-pushed
the
feat/contracts/erc20-bridge-sampler/graceful-reverts
branch
from
7737a9c to
b5d7b22
Compare
abandeali1
reviewed
Dec 13, 2019
| /// @dev Address of the 0x Exchange contract. | ||
| address constant public EXCHANGE_ADDRESS = 0x080bf510FCbF18b91105470639e9561022937712; | ||
| /// @dev Address of the 0x DevUtils contract. | ||
| address constant public DEVUTILS_ADDRESS = 0xcCc2431a7335F21d9268bA62F0B32B0f2EFC463f; |
There was a problem hiding this comment.
Why not use MixinDeploymentConstants in the contracts-utils package for this?
Also nit: this should be DEV_UTILS_ADDRESS.
There was a problem hiding this comment.
If we're OK with adding kyber and all that jazz to it, sure.
There was a problem hiding this comment.
Oh they already are there 🙃
There was a problem hiding this comment.
I'm fine with it. The unused internal functions won't be part of the bytecode anyways from my understanding.
| )); | ||
| uint256 rate = 0; | ||
| if (didSucceed) { | ||
| (rate,) = abi.decode(resultData, (uint256, uint256)); |
There was a problem hiding this comment.
(rate,) = abi.decode(resultData, (uint256)) would be a bit more efficient here.
| // convert them to maker asset amounts. | ||
| for (uint256 i = 0; i < orders.length; ++i) { | ||
| if (orderFillableMakerAssetAmounts[i] != 0) { | ||
| orderFillableMakerAssetAmounts[i] = LibMath.getPartialAmountFloor( |
There was a problem hiding this comment.
Do we want to use getPartialAmountCeil here? This will underestimate the actual fillable amount.
…` to `DeploymentConstants`.
dorothy-zbornak
force-pushed
the
feat/contracts/erc20-bridge-sampler/graceful-reverts
branch
2 times, most recently
from
8e04b8b to
3a1ac4f
Compare
dorothy-zbornak
force-pushed
the
feat/contracts/erc20-bridge-sampler/graceful-reverts
branch
from
3a1ac4f to
ebccf10
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Quoting external DEXes can revert if the market does not exist (e.g., asking Eth2Dai for ZRX). We could whitelist/blacklist exchanges from pairs in asset-swapper, but it's simpler to just swallow these errors and return zero for the quotes in the sampler contract.
In addition, the sampler will no longer query fillable status for native orders with either:
makerAssetAmounttakerAssetAmountThis is to simplify the case where we don't have any native orders to pass to the sampler, which the sampler needs to extract the token information. Previously we had to clumsily pass in an order with
1in the asset amounts and aWalletsignature type.Testing instructions
Types of changes
Checklist:
[WIP]if necessary.