Swallow reverts in ERC20BridgeSampler (#2395)

* `@0x/erc20-bridge-sampler`: Do not query empty/unsigned orders. Swallow revets on DEX quotes. * `@0x/contracts-utils`: Add `DEV_UTILS_ADDRESS` and `KYBER_ETH_ADDRESS` to `DeploymentConstants`. * `@0x/contracts-erc20-bridge-sampler`: Address review comments.
0xProject · Dec 13, 2019 · 70870ff · 70870ff
1 parent a556d91
commit 70870ff
Show file tree

Hide file tree

Showing 13 changed files with 716 additions and 310 deletions.
diff --git a/contracts/erc20-bridge-sampler/CHANGELOG.json b/contracts/erc20-bridge-sampler/CHANGELOG.json
@@ -1,4 +1,13 @@
 [
+    {
+        "version": "1.0.2",
+        "changes": [
+            {
+                "note": "Do not query empty/unsigned orders. Swallow revets on DEX quotes.",
+                "pr": 2365
+            }
+        ]
+    },
     {
         "timestamp": 1575931811,
         "version": "1.0.1",

diff --git a/contracts/erc20-bridge-sampler/contracts/src/DeploymentConstants.sol b/contracts/erc20-bridge-sampler/contracts/src/DeploymentConstants.sol