Make wrappers small again #2243

xianny · 2019-10-04T18:44:19Z

Currently our generated contract wrappers are much too big. This adds to bundlesize bloat and also makes our MD docs much too large, causing size deploys to take over an hour and Algolia to timeout on indexing them. Let’s make them smaller.
-- @fabioberger

Description

I'm tagging a long list of reviewers to include everyone who might need to know about these changes. Protocol team, please note interface changes to sendTransactionAsync and awaitTransactionSuccessAsync.

Changes:

makes evmExecAsync protected
stop generating docs for deployedBytecode
trim deployedBytecode so it's undefined unless a contract as pure functions
only generate getABIEncodedTransactionData for non-constant functions, or if in debug mode
only generate getABIDecodedTransactionData and getABIDecodedReturnData in debug mode
remove validateAndSendTransactionAsync. Allow to provide a shouldValidate optional argument instead
Introduce a SendTransactionOpts type for non-ethereum transaction options:

{ 
    shouldValidate?: boolean; // default true
    timeoutMs?: number;
    pollingIntervalMs?: number
}

Debug mode is enabled for all contracts/* packages as they are not published.

Results
0x.js MD file: 849KB --> 509KB
Contract-wrappers MD file: 1.4MB --> 811KB
abi-gen-wrappers lib size: 5.0MB -> 3.7 MB (3.8 without trimming bytecode)

Testing instructions

Types of changes

Checklist:

Prefix PR title with [WIP] if necessary.
Add tests to cover changes as needed.
Update documentation as needed.
Add new entries to the relevant CHANGELOG.jsons.

…appers

packages/abi-gen/templates/TypeScript/partials/method_abi_helper.handlebars

xianny · 2019-10-07T18:49:53Z

packages/abi-gen/templates/TypeScript/contract.handlebars

@@ -48,6 +48,9 @@ export enum {{contractName}}Events {
 // tslint:disable:no-parameter-reassignment
 // tslint:disable-next-line:class-name
 export class {{contractName}}Contract extends BaseContract {
+    /**
+     * @ignore


tells typedoc to skip the next line when generating!

xianny · 2019-10-07T18:50:22Z

contracts/utils/test/ownable.ts

@@ -49,7 +49,13 @@ describe('Ownable', () => {
        });

        it('should transfer ownership if the specified new owner is not the zero address', async () => {
-            expect(ownable.transferOwnership.sendTransactionAsync(nonOwner, { from: owner })).to.be.fulfilled('');
+            expect(


not sure how this worked before 🤔

My guess: Because the promise returned by sendTransactionAsync() was indeed resolved, and ganache updated the "chain" super fast (it doesn't actually "mine" anything, right?), so fast that the subsequent .owner.callAsync() was able to get the data it expected. I'd also guess that it would have failed intermittently, especially on a machine under high load.

That makes sense. This is the first time I ran this test locally :)

coveralls · 2019-10-07T19:07:10Z

Coverage remained the same at 75.286% when pulling 299c2ed on fix/concise-wrappers into 2319817 on 3.0.

buildsize · 2019-10-08T00:02:21Z

File name	Previous Size	New Size	Change
init.py	7.04 KB	7.14 KB	100 bytes (1%)
abi_gen_dummy.ts	175.17 KB	189.11 KB	13.95 KB (8%)
lib_dummy.ts	5.28 KB	5.32 KB	39 bytes (1%)
test_lib_dummy.ts	14.06 KB	14.1 KB	41 bytes (0%)

feuGeneA

If we're trying to make wrappers small again, and, given the bundle size bloat mentioned in the quote from @fabioberger , can we also delve into bundle size?

In particular, can we use this PR as a vehicle for discussing the recently introduced dependency on ethereumjs-vm (for supporting local-machine execution of pure Solidity functions)? @dekz was complaining to me about it last week. In informal conversation, he said ethereumjs-vm added 2 MB to the bundle size. bundlephobia says it's 1.8 MB minified, and 569 KB minified and gzipped. In short, it's huge!

It would make a world of difference if we could make that functionality optional. But wouldn't we have to publish a separate package? Something like @0x/abi-gen-wrappers-evm? What would we have to take into consideration in order to make this happen? And, what other approaches could we consider?

Also, I was thinking about another way to reduce bundle size. Since we're hardcoding ABI's into the generated wrappers, why can't we change the abi-gen-wrappers/package.json to make @0x/contract-artifacts be in devDependencies instead of a regular dependencies? bundlephobia says @0x/contract-artifacts is 380 KB minified, and 67 KB minified+gzipped. So, not a huge impact, but it seems like an easy win, no?

Also, a question about embedding deployedBytecode in the wrappers: do we decide whether to embed it based on whether the contract actually has any pure functions? Or do we just embed it regardless? Some quick measurements show that by avoiding embedding for contracts that don't even have any pure functions, we can reduce total deployedBytecode string length from 209 KB to 86 KB (gzipped size reduced from 21 KB to 7 KB). (I just duplicated contract-artifacts/lib to lib2, then rm'd all artifacts that don't mention pure, then did:

 8Oct12:59:03 ~/dev/0x-monorepo-v3/packages/contract-artifacts[feat/3.0/python *$%]$ grep -A1 'deployedBytecode\": {' lib/artifacts/*.json | wc -m
214049
 8Oct12:59:30 ~/dev/0x-monorepo-v3/packages/contract-artifacts[feat/3.0/python *$%]$ grep -A1 'deployedBytecode\": {' lib2/artifacts/*.json | wc -m
87847
 8Oct12:59:31 ~/dev/0x-monorepo-v3/packages/contract-artifacts[feat/3.0/python *$%]$ grep -A1 'deployedBytecode\": {' lib2/artifacts/*.json | gzip | wc -m
7600
 8Oct12:59:59 ~/dev/0x-monorepo-v3/packages/contract-artifacts[feat/3.0/python *$%]$ grep -A1 'deployedBytecode\": {' lib/artifacts/*.json | gzip | wc -m
21487

)

Perhaps at the very least (before embarking on any more actual work targeting reduced bundle size), could you update the Results section of your OP to show how bundle size has changed in light of the changes already present in this PR? I'm not an expert on our publishing process (do we minify, via webpack or something?), but I think a good proxy for bundle size is to just do du -h on a package's lib directory; and to get a gzipped size, you can do tar czO lib | wc -c (read as: "use tar to create (c) a zipped (z) file, printed to stdout (O) and piped through the word count utility (wc) to count bytes (-c)).

(Done ranting about bundle size...)

Are those now-debug functions really just for debug? It seems like they're useful for other purposes too (though admittedly for more advanced/complex use cases), such as for example for preparing ABI-encoded calldata so that it can be signed locally before sending it off to a remote node for execution.

Also, as much as I hate to say this, the introduction of the --debug flag exposes a weakness in our test-cli setup. Specifically, our existing structure is only set up to test a single set of arguments to abi-gen. Really, we should be testing all sorts of combinations: with and without --debug, with and without --template and --partials, etc. Perhaps this is out of scope for this PR, but perhaps we should raise an Issue to discuss and specify how we could reasonably accomplish this.

feuGeneA · 2019-10-08T16:04:05Z

packages/types/src/index.ts

+ * shouldValidate: Flag indicating whether the library should make attempts to validate a transaction before
+ * broadcasting it. For example, order has a valid signature, maker has sufficient funds, etc. Default=true.
+ */
+export interface TxOpts {


I'm no expert on this, but I think this name incorrectly suggests that it relates directly to an Ethereum transaction, whereas this thing's usage is more indirect. Maybe SendTransactionOptions, TxSendOptions, or some variation thereof? 🤷‍♂️

Ya good point. Going with SendTransactionOpts (to match sendTransaction method name)

feuGeneA · 2019-10-08T16:25:24Z

contracts/utils/test/ownable.ts

@@ -49,7 +49,13 @@ describe('Ownable', () => {
        });

        it('should transfer ownership if the specified new owner is not the zero address', async () => {
-            expect(ownable.transferOwnership.sendTransactionAsync(nonOwner, { from: owner })).to.be.fulfilled('');
+            expect(


My guess: Because the promise returned by sendTransactionAsync() was indeed resolved, and ganache updated the "chain" super fast (it doesn't actually "mine" anything, right?), so fast that the subsequent .owner.callAsync() was able to get the data it expected. I'd also guess that it would have failed intermittently, especially on a machine under high load.

feuGeneA · 2019-10-08T16:35:12Z

packages/abi-gen-wrappers/src/generated-wrappers/asset_proxy_owner.ts

-                        pollingIntervalMs,
-                        timeoutMs,
+                        opts.pollingIntervalMs,
+                        opts.timeoutMs,


Should we also update awaitTransactionSuccessAsync() to also take a TxOpts object?

I intentionally didn't change web3wrapper because the arguments for awaitTransactionSuccessAsync(txHash, pollingIntervalMs, timeoutMs) don't have overlap with sendTransactionAsync(txData). They are pretty different steps.

awaitTransactionSuccessAsync in the contract wrappers has been updated to take TxOpts though.

In the contract-wrapper class, awaitTransactionSuccessAsync is a convenience that calls web3Wrapper.sendTransactionAsync(txData), retrieves the txhash, then calls web3Wrapper.awaitTransactionSuccessAsync(txHash). Thus sendTransactionAsync() is a subset of awaitTransactionSuccessAsync(). I created the TxOpts object to 1. further abstract the differences between the two away so a developer can call both with the same arguments, and 2. allow us more flexibility to add or remove optional args later, but those dont apply for web3wrapper.

feuGeneA · 2019-10-08T16:38:08Z

packages/abi-gen-wrappers/src/generated-wrappers/asset_proxy_owner.ts

+        async sendTransactionAsync(
+            owner: string,
+            txData?: Partial<TxData> | undefined,
+            opts: TxOpts = { shouldValidate: true },


Just pointing out for other reviewers here: we're changing the default behavior of this (generated) function such that now it will do an eth_call first, and then actually do an eth_sendTranscation, whereas before we had a separate method to do that combo (validateAndSendTransactionAsync()). Is that what we want? It makes sense to me, but I wanted to be sure to raise the visibility of this change.

This was also the default behaviour a few months back before we started the whole multi-lang/abi-gen project. Neither @feuGeneA nor myself understood the importance of performing an eth_call first so I treated it as an optional step! But have since learned that it's a good idea to always validate before sending a tx.

feuGeneA · 2019-10-08T16:43:44Z

packages/abi-gen/src/index.ts

@@ -73,12 +77,11 @@ const args = yargs
        default: 'TypeScript',
    })
    .example(
-        "$0 --abis 'src/artifacts/**/*.json' --out 'src/contracts/generated/' --partials 'src/templates/partials/**/*.handlebars' --template 'src/templates/contract.handlebars'",
+        "$0 --abis 'src/artifacts/**/*.json' --out 'src/contracts/generated/' --debug --partials 'src/templates/partials/**/*.handlebars' --template 'src/templates/contract.handlebars'",


Definitely a nit, but I'd prefer to make the example as simple as possible, so I would skip the --debug here, and I would actually advocate for removing --partials and --handlebars as well, though admittedly that doesn't necessarily feel in context for this PR.

Hmmmm shouldn't we make the example use all the options so that it provides more complete info? Folks can ignore whatever doesn't apply to them.

Definitely a matter of opinion. I think of it as a one-liner "quick start guide", and the easiest way to "get started" is by accepting the defaults. People can always find usages "in the wild" (eg our other packages) if they want to see more complex examples. I'm open to having my mind changed though.

I think I agree with Xianny that a more complete example is potentially more helpful. It's easier to remove then to know how to add.

feuGeneA · 2019-10-08T16:45:10Z

packages/abi-gen/src/index.ts

@@ -44,6 +44,10 @@ const args = yargs
        normalize: true,
        demandOption: true,
    })
+    .option('debug', {
+        describe: 'Enable debug functions',
+        type: 'count',


why not

Suggested change

type: 'count',

type: 'boolean',

?

For some reason I thought that would imply --debug=true or --debug=false, but you are totally right, it works the same. Thank you!

feuGeneA · 2019-10-08T16:46:15Z

packages/abi-gen/src/index.ts

@@ -425,6 +428,7 @@ for (const abiFileName of abiFileNames) {
        ABIString: JSON.stringify(ABI),
        methods: methodsData,
        events: eventsData,
+        debug: args.debug > 0,


If args.debug should be type: "boolean", then this should just be

Suggested change

debug: args.debug > 0,

debug: args.debug,

...right?

feuGeneA · 2019-10-08T17:03:43Z

packages/abi-gen/test-cli/output/typescript/abi_gen_dummy.ts

 import { Web3Wrapper } from '@0x/web3-wrapper';
 import { assert } from '@0x/assert';
 import * as ethers from 'ethers';
 // tslint:enable:no-unused-variable

-export type AbiGenDummyEventArgs = AbiGenDummyWithdrawalEventArgs | AbiGenDummySimpleEventEventArgs;
+export type AbiGenDummyEventArgs = AbiGenDummySimpleEventEventArgs | AbiGenDummyWithdrawalEventArgs;


Is this ordering nondeterministic?

It's deterministic but the latest version of sol-compiler uses soljson-v0.5.12, whereas the existing artifacts were compiled with soljson-v0.5.10. So I assume this has something to do with the ordering.

I actually found an existing method in the dummy contract that let me do what I needed, so I removed the contract changes and reverted the artifact. We should open a separate PR just to update the artifacts though so that future diffs will be clean. I'll open an issue and do it after this one is merged. #2251

feuGeneA · 2019-10-08T17:19:35Z

packages/abi-gen/test-cli/output/typescript/abi_gen_dummy.ts

            return abiDecodedReturnData;
        },
    };
-    public methodReturningArrayOfStructs = {
+    public simplePureFunction = {


Is the order of methods in the generated wrapper non-deterministic? That would be really unfortunate... It seems like there's a ton of "noise" in this diff due simply to a re-ordering of method declarations. If that's the case, we should consider sorting them before generating them. Out of scope for this PR of course, but maybe we should make an Issue about it.

see #2243 (comment)

feuGeneA · 2019-10-08T17:27:43Z

packages/base-contract/src/index.ts

@@ -184,7 +184,7 @@ export class BaseContract {
        }
        return rawEncoded;
    }
-    public async evmExecAsync(input: Buffer): Promise<string> {
+    protected async _evmExecAsync(input: Buffer): Promise<string> {


Is the reason for this just to avoid having documentation for it generated into the markdown files? Or is there some other reason as well?

Partly to avoid having docs generated, partly because it's not used anywhere else, so follows the principle of minimum exposed surfaces.

It doesn't make a whole lotta sense to call it in an external context. It only works for functions defined in the Solidity and available via bytecode; and those should all be accessed by calling functionName.callAsync or similar. I have a feeling we should also avoid bypassing those to directly pass in callData even for unit tests because that would be an easy way to create holes in our testing.

* revert artifacts to get rid of ordering diffs * trim deployedBytecode so it's undefined unless a contract has pure functions * rename TxOpts -> SendTransactionOpts * create sendTransactionOptsSchema in json-schemas * fix dependencies in @0x/abi-gen-wrappers

xianny · 2019-10-08T21:02:58Z

Thanks for looking into the bundle size @feuGeneA ! I agree that the bundle is pretty large right now and a lot of it is due to ethereumjs-vm. That's a whole can of worms though, so I'll address other points first:

tried trimming bytecode as you suggested from contracts without pure functions. This drops .1 MB from the uncompressed lib size
changed contract-artifacts to a devDependency in abi-gen-wrappers; not sure how much this changed since I did not bundle it, but assuming it drops contract-artifacts from whatever needs to be downloaded from npm
the changes here so far have changed uncompressed size from 5.0MB to 3.7MB! I updated the OP with this
debug functions: we are actually keeping getABIEncodedTransactionData because you are right that it is useful for forwarder contracts. But I did remove it from pure/view functions because that doesn't apply in those cases! The debug functions are the two that @hsyz added recently, getABIDecodedTransactionData and getABIDecodedReturnData and I think those really are very specific for protocol team unit testing cases
testing setup: Our setup currently tests our specific templates and partials. The abi-gen utility doesn't make a whole lot of sense without templates, so I think it's OK to provide a "safe default" and test them together. Having a hard time picturing how to test abi-gen without the template or partials but definitely open to ideas. I would also argue that the debug flag isn't really a combinatorial scenario but more of a subset/superset, so if we test the superset we're OK.

Re: ethereumjs-vm dependency, yeah it's huge :/ but the previous consensus has been that it's worth it. Maybe we need to revisit this, but that seems out of scope for this PR. From the POV of an external developer I'm also not 100% convinced that I would prefer to use DevUtilsContract (with ethereumjs-vm) over pre-existing @0x/order-utils. The trade-off is that internally it's much easier for us to maintain. I'm definitely open to having that discussion, but would rather it not block this PR, since the original goal is just to enable us to upload docs!

feuGeneA

Drop JSON schema validations. Otherwise everything looks good to me!

feuGeneA · 2019-10-08T22:07:25Z

packages/abi-gen/src/index.ts

@@ -420,15 +420,17 @@ for (const abiFileName of abiFileNames) {
        return eventData;
    });

+    const shouldIncludeBytecode = methodsData.find(methodData => methodData.stateMutability === 'pure') !== undefined;


fabioberger · 2019-10-10T09:33:33Z

contracts/utils/test/ownable.ts

+                ownable.transferOwnership.awaitTransactionSuccessAsync(
+                    nonOwner,
+                    { from: owner },
+                    { timeoutMs: constants.AWAIT_TRANSACTION_MINED_MS },


There is a default value for this right?

Now there is :)

fabioberger · 2019-10-10T09:35:35Z

packages/abi-gen/src/index.ts

@@ -44,6 +44,10 @@ const args = yargs
        normalize: true,
        demandOption: true,
    })
+    .option('debug', {
+        describe: 'Enable debug functions',


Suggested change

describe: 'Enable debug functions',

describe: 'Includes debug functions in the wrappers such as `getABIDecodedTransactionData`',

fabioberger · 2019-10-10T09:36:32Z

packages/abi-gen/src/index.ts

@@ -73,12 +77,11 @@ const args = yargs
        default: 'TypeScript',
    })
    .example(
-        "$0 --abis 'src/artifacts/**/*.json' --out 'src/contracts/generated/' --partials 'src/templates/partials/**/*.handlebars' --template 'src/templates/contract.handlebars'",
+        "$0 --abis 'src/artifacts/**/*.json' --out 'src/contracts/generated/' --debug --partials 'src/templates/partials/**/*.handlebars' --template 'src/templates/contract.handlebars'",


I think I agree with Xianny that a more complete example is potentially more helpful. It's easier to remove then to know how to add.

packages/abi-gen/templates/TypeScript/partials/method_abi_helper.handlebars

fabioberger · 2019-10-10T09:42:17Z

packages/abi-gen/templates/TypeScript/partials/method_tx.handlebars

@@ -8,6 +8,7 @@
 async sendTransactionAsync(
 {{> typed_params inputs=inputs}}
 txData?: Partial<TxData> | undefined,
+opts: SendTransactionOpts = { shouldValidate: true },


It's a bit strange that if you pass in pollingIntervalMs or timeoutMs here, it won't do anything and doesn't really make sense. Probably cleaner to have a separate opts type for this method and awaitTransactionSuccessAsync. The one for awaitTransactionSuccessAsync can be a super-set of the type for sendTransactionAsync.

That makes complete sense. I kind of forgot about TypeScript type system ^^"

xianny · 2019-10-10T20:56:17Z

packages/base-contract/src/types.ts

-
-export interface IndexedFilterValues {
-    [index: string]: ContractEventArg;
-}


These were all duplicated in @0x/types

* Create `AwaitTransactionSuccessOpts` type with default timeoutMs value * Remove duplicate types `IndexedFilterValues`, `DecodedLogEvent`, `EventCallback` from `@0x/base-contract` * Better comments

fabioberger

Please address my one last comment before merging.

fabioberger · 2019-10-11T03:50:57Z

packages/abi-gen/test-cli/output/typescript/abi_gen_dummy.ts

@@ -323,7 +329,7 @@ export class AbiGenDummyContract extends BaseContract {
        awaitTransactionSuccessAsync(
            wad: BigNumber,
            txData?: Partial<TxData>,
-            opts: SendTransactionOpts = { shouldValidate: true },
+            opts: AwaitTransactionSuccessOpts = { shouldValidate: true, timeoutMs: 0 },


Defaulting timeoutMs to 0 doesn't make any sense. From the doc comment, this is: How long (in ms) to poll for transaction mined until aborting.. Aborting after 0 MS makes it impossible for the poll request to complete. Am I missing something?

Ahh good catch. This should be pollingIntervalMs and was only set to 0 in contracts unit tests. @0x/web3wrapper has a default pollingIntervalMs = 1000 already so I will leave the wrapper without a default value and keep the existing behaviour.

…ided in web3wrapper

* introduce --debug option to abi-gen and remove debug functions from @0x/abi-gen-wrappers * make evmExecAsync protected; ignore deployedBytecode in doc comment * trim deployedBytecode so it's undefined unless a contract has pure functions * remove validateAndSendTransactionAsync * Create `AwaitTransactionSuccessOpts` and `SendTransactionOpts` types * Remove duplicate types `IndexedFilterValues`, `DecodedLogEvent`, `EventCallback` from `@0x/base-contract`

introduce debug option and remove debug functions from @0x/abi-gen-wr…

99d9a95

…appers

xianny force-pushed the fix/concise-wrappers branch 3 times, most recently from 5744166 to 72021c7 Compare October 4, 2019 23:09

make evmExecAsync protected; ignore deployedBytecode in doc comment

7aa4b4e

xianny force-pushed the fix/concise-wrappers branch from 72021c7 to 67f4803 Compare October 7, 2019 16:36

xianny added 2 commits October 7, 2019 11:46

remove validateAndSendTransactionAsync

9e6767c

update changelogs

bafae3f

xianny force-pushed the fix/concise-wrappers branch from fa10d8b to bafae3f Compare October 7, 2019 18:46

xianny commented Oct 7, 2019

View reviewed changes

packages/abi-gen/templates/TypeScript/partials/method_abi_helper.handlebars Show resolved Hide resolved

xianny commented Oct 7, 2019

View reviewed changes

xianny requested review from hysz, jalextowle, abandeali1, dorothy-zbornak, fabioberger, feuGeneA and dekz October 7, 2019 19:09

xianny force-pushed the fix/concise-wrappers branch from af136a9 to bafae3f Compare October 7, 2019 23:55

xianny marked this pull request as ready for review October 7, 2019 23:56

xianny requested review from BMillman19, fragosti and steveklebanoff as code owners October 7, 2019 23:56

feuGeneA suggested changes Oct 8, 2019

View reviewed changes

feuGeneA assigned feuGeneA and xianny Oct 8, 2019

xianny assigned fabioberger Oct 8, 2019

xianny force-pushed the fix/concise-wrappers branch from 5e08cbc to e2568b8 Compare October 8, 2019 20:38

Tweaks to address review:

0383ebd

* revert artifacts to get rid of ordering diffs * trim deployedBytecode so it's undefined unless a contract has pure functions * rename TxOpts -> SendTransactionOpts * create sendTransactionOptsSchema in json-schemas * fix dependencies in @0x/abi-gen-wrappers

xianny force-pushed the fix/concise-wrappers branch from e2568b8 to 0383ebd Compare October 8, 2019 20:41

xianny mentioned this pull request Oct 8, 2019

Update testing artifacts in abi-gen #2251

Closed

feuGeneA suggested changes Oct 8, 2019

View reviewed changes

remove sendTransactionOptsSchema

95c5a4a

feuGeneA approved these changes Oct 8, 2019

View reviewed changes

fabioberger suggested changes Oct 10, 2019

View reviewed changes

xianny commented Oct 10, 2019

View reviewed changes

xianny force-pushed the fix/concise-wrappers branch from 4d52d83 to 630e4c6 Compare October 10, 2019 21:38

Tweaks after review

805c9bc

* Create `AwaitTransactionSuccessOpts` type with default timeoutMs value * Remove duplicate types `IndexedFilterValues`, `DecodedLogEvent`, `EventCallback` from `@0x/base-contract` * Better comments

xianny force-pushed the fix/concise-wrappers branch from 630e4c6 to 805c9bc Compare October 10, 2019 22:34

xianny requested a review from fabioberger October 11, 2019 00:40

fabioberger approved these changes Oct 11, 2019

View reviewed changes

xianny force-pushed the fix/concise-wrappers branch 2 times, most recently from f3cf65e to 7e30376 Compare October 16, 2019 02:01

remove default value for timeoutMs; default pollingIntervalMs is prov…

3750545

…ided in web3wrapper

xianny force-pushed the fix/concise-wrappers branch from 7e30376 to 3750545 Compare October 16, 2019 16:05

Merge branch '3.0' into fix/concise-wrappers

299c2ed

xianny merged commit 0e90b0e into 3.0 Oct 16, 2019

xianny deleted the fix/concise-wrappers branch October 16, 2019 16:38

	describe: 'Enable debug functions',
	describe: 'Includes debug functions in the wrappers such as `getABIDecodedTransactionData`',

Make wrappers small again #2243

Make wrappers small again #2243

Conversation

xianny commented Oct 4, 2019 • edited Loading

Description

Testing instructions

Types of changes

Checklist:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Oct 7, 2019 • edited Loading

buildsize bot commented Oct 8, 2019

feuGeneA left a comment

Choose a reason for hiding this comment

feuGeneA Oct 8, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xianny Oct 8, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xianny Oct 8, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xianny commented Oct 8, 2019

feuGeneA left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fabioberger left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xianny commented Oct 4, 2019 •

edited

Loading

coveralls commented Oct 7, 2019 •

edited

Loading

feuGeneA Oct 8, 2019 •

edited

Loading

xianny Oct 8, 2019 •

edited

Loading

xianny Oct 8, 2019 •

edited

Loading