Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

Prettify generated code for easier diffing #1944

Merged
merged 1 commit into from
Jul 11, 2019

Conversation

xianny
Copy link
Contributor

@xianny xianny commented Jul 11, 2019

Description

Generated, checked in code is susceptible to confusing whitespace diffs unless it is uniformly prettified. This PR prettifies the following:

  • packages/abi-gen/test-cli/expected-output
  • packages/abi-gen/test-cli/fixtures/artifacts
  • packages/abi-gen-wrappers/src/generated-wrappers
  • packages/contract-artifacts/artifacts
  • python-packages/.../contract_artifacts

Resolves #1917

Testing instructions

None of the above paths should be in .prettierignore. CI should pass.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

@xianny xianny requested review from fabioberger and feuGeneA July 11, 2019 16:19
@xianny xianny requested a review from albrow as a code owner July 11, 2019 16:19
@xianny xianny force-pushed the multilang-1917/prettify-abigen branch from 7e90ddc to ab601e3 Compare July 11, 2019 16:20
@xianny xianny force-pushed the multilang-1917/prettify-abigen branch from ab601e3 to e7155d2 Compare July 11, 2019 16:34
@xianny xianny changed the title Prettify generated code for easier diffing [WIP] Prettify generated code for easier diffing Jul 11, 2019
@xianny xianny force-pushed the multilang-1917/prettify-abigen branch from e7155d2 to b5a7a08 Compare July 11, 2019 22:35
@xianny xianny changed the title [WIP] Prettify generated code for easier diffing Prettify generated code for easier diffing Jul 11, 2019
@xianny xianny force-pushed the multilang-1917/prettify-abigen branch from b5a7a08 to 380d55d Compare July 11, 2019 22:36
@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 83.267% when pulling 380d55d on multilang-1917/prettify-abigen into e6c70fd on development.

@xianny xianny merged commit ccb89fb into development Jul 11, 2019
@xianny xianny deleted the multilang-1917/prettify-abigen branch October 8, 2019 00:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prettify abi-gen
3 participants