You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
prettier should be run as part of abi-gen. We are currently checking in generated-wrappers so that we can compare diffs when reviewing. Prettifying will minimise the amount of whitespace/formatting diffs and make reviews easier, and should be enforced immediately after generating wrappers.
Current Behavior
prettier must be run when building/as part of build scripts. We're doing extensive work on abi-gen right now and run into whitespace conflicts, huge unnecessary diffs, etc.
Possible Solution
Implement prettier within the abi-gen code generation script.
The text was updated successfully, but these errors were encountered:
Just one more quick note on motivation. As much as possible, we should be generating not just working code, but good code. It's not hard to use prettier within a run of abi-gen, so we should!
Expected Behavior
prettier
should be run as part of abi-gen. We are currently checking ingenerated-wrappers
so that we can compare diffs when reviewing. Prettifying will minimise the amount of whitespace/formatting diffs and make reviews easier, and should be enforced immediately after generating wrappers.Current Behavior
prettier
must be run when building/as part of build scripts. We're doing extensive work onabi-gen
right now and run into whitespace conflicts, huge unnecessary diffs, etc.Possible Solution
Implement
prettier
within theabi-gen
code generation script.The text was updated successfully, but these errors were encountered: