Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

Prettify abi-gen #1917

Closed
xianny opened this issue Jul 2, 2019 · 1 comment · Fixed by #1944
Closed

Prettify abi-gen #1917

xianny opened this issue Jul 2, 2019 · 1 comment · Fixed by #1944

Comments

@xianny
Copy link
Contributor

xianny commented Jul 2, 2019

Expected Behavior

prettier should be run as part of abi-gen. We are currently checking in generated-wrappers so that we can compare diffs when reviewing. Prettifying will minimise the amount of whitespace/formatting diffs and make reviews easier, and should be enforced immediately after generating wrappers.

Current Behavior

prettier must be run when building/as part of build scripts. We're doing extensive work on abi-gen right now and run into whitespace conflicts, huge unnecessary diffs, etc.

Possible Solution

Implement prettier within the abi-gen code generation script.

@feuGeneA
Copy link
Contributor

feuGeneA commented Jul 3, 2019

Just one more quick note on motivation. As much as possible, we should be generating not just working code, but good code. It's not hard to use prettier within a run of abi-gen, so we should!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants