Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

Fix bug in Trezor implementation #1867

Merged
merged 2 commits into from
Jun 17, 2019
Merged

Fix bug in Trezor implementation #1867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66ec3e9
Hex should be true since the data returned expects it to be hex encoded
Jun 16, 2019
5f38343
Add CHANGELOG entry
Jun 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/subproviders/CHANGELOG.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,13 @@
[
{
"version": "4.1.1",
"changes": [
{
"note": "Fix bug in Trezor subprovider causing Trezor response to not be hex encoded",
"pr": 1867
}
]
},
{
"version": "4.1.0",
"changes": [
Expand Down
2 changes: 1 addition & 1 deletion packages/subproviders/src/subproviders/trezor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ export class TrezorSubprovider extends BaseWalletSubprovider {
const response: TrezorConnectResponse = await this._trezorConnectClientApi.ethereumSignMessage({
path: fullDerivationPath,
message: data,
hex: false,
hex: true,
});

if (response.success) {
Expand Down