Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

Fix bug in Trezor implementation #1867

Merged
merged 2 commits into from
Jun 17, 2019
Merged

Fix bug in Trezor implementation #1867

merged 2 commits into from
Jun 17, 2019

Conversation

fabioberger
Copy link
Contributor

Description

Fixes: #1838

Testing instructions

Types of changes

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

@fabioberger fabioberger requested a review from dekz as a code owner June 16, 2019 04:24
@fabioberger fabioberger mentioned this pull request Jun 16, 2019
Closed
@coveralls
Copy link

coveralls commented Jun 16, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 83.353% when pulling 5f38343 on fix/trezorSubprovider into c269c42 on development.

dekz
dekz approved these changes Jun 17, 2019
View reviewed changes
Copy link
Member

@dekz dekz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We asked Trezor to implement this hex option so it wouldn't translate the incoming hex to utf-8 and loose "precision". Since some values present in hex cannot be represented in utf-8.

@fabioberger fabioberger merged commit 2672a5c into development Jun 17, 2019
@fabioberger fabioberger deleted the fix/trezorSubprovider branch June 17, 2019 17:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dekz dekz dekz approved these changes

Assignees
No one assigned
Labels
@0x/subproviders
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

subproviders: Orders Signed By Trezor Returns INVALID_SIGNATURE
3 participants
@fabioberger @coveralls @dekz