Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

Hook eth_sendRawTransaction in addition to eth_sendTransaction #1584

Merged
merged 1 commit into from
Feb 5, 2019

Conversation

jeremyschlatter
Copy link
Contributor

Description

TraceCollectionSubprovider currently traces calls to eth_sendTransaction, eth_call, and eth_estimateGas. This change adds eth_sendRawTransaction to that list.

Background:

I was trying out sol-coverage on a new project and the first time I tried it, sol-coverage reported that none of my statements were covered. I looked into it and discovered that it was because my tests were sending all of their transactions with eth_sendRawTransaction, which TraceCollectionSubprovider wasn't tracing. After making the change in this PR (and the change in #1583) , my coverage report is as I expected.

Testing instructions

I don't have an easy-to-reproduce test case prepared. I didn't see existing tests that covered the previous hooks, so it seemed like quite a bit of marginal work to create a test for this. Let me know if that's a blocker.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

Copy link
Contributor

@LogvinovLeon LogvinovLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants