This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
Hook eth_sendRawTransaction in addition to eth_sendTransaction #1584
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TraceCollectionSubprovider
currently traces calls toeth_sendTransaction
,eth_call
, andeth_estimateGas
. This change addseth_sendRawTransaction
to that list.Background:
I was trying out sol-coverage on a new project and the first time I tried it, sol-coverage reported that none of my statements were covered. I looked into it and discovered that it was because my tests were sending all of their transactions with
eth_sendRawTransaction
, whichTraceCollectionSubprovider
wasn't tracing. After making the change in this PR (and the change in #1583) , my coverage report is as I expected.Testing instructions
I don't have an easy-to-reproduce test case prepared. I didn't see existing tests that covered the previous hooks, so it seemed like quite a bit of marginal work to create a test for this. Let me know if that's a blocker.
Types of changes
Checklist:
[WIP]
if necessary.