This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
Fix default gas limit for fake txs in TraceCollectionSubprovider #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hex string is required to be prefixed with '0x'. If it does not have that prefix, then the call to unmarshalTxData below will fail with: BigNumber Error: new BigNumber() not a number: 5b8d80 This default value is overridden if the incoming call already has a gas estimate, in which case the parse error above does not happen. This is probably why the error wasn't previously noticed.
4 tasks
This was referenced Oct 9, 2021
Open
Open
This was referenced Feb 4, 2022
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This hex string is required to be prefixed with '0x'. If it does not have that
prefix, then the call to unmarshalTxData below will fail with:
This default value is overridden if the incoming call already has a gas
estimate, in which case the parse error above does not happen. This is probably
why the error wasn't previously noticed.
Testing instructions
Types of changes
Checklist:
[WIP]if necessary.