Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obsolete block time flag from server command #1365

Merged
merged 5 commits into from
Apr 7, 2023
Merged

Obsolete block time flag from server command #1365

merged 5 commits into from
Apr 7, 2023

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Apr 6, 2023 •
edited
Loading

Description

This PR removes block-time flag from the server command and server config. Instead, it resolves it from a consensus engine parameters map. PolyBFT and IBFT consensus protocols have defined block time. Dev and Dummy consensuses are initialized with 0 block time, as those are used solely for testing.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@flavor-town
refactor(server): remove block time configuration from raw config and…
c4784a7 
… server params (#1363)

The block time configuration was removed from the raw config and server params. The initBlockTime function was also removed from the server params.
@Stefan-Ethernal Stefan-Ethernal self-assigned this Apr 6, 2023
@Stefan-Ethernal Stefan-Ethernal added feature New update to Polygon Edge breaking change Functionality that contains breaking changes labels Apr 6, 2023
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-571-obsolete-block-time-from-server-cmd branch from 468cdbc to 23568bf Compare April 6, 2023 11:41
@Stefan-Ethernal Stefan-Ethernal requested a review from a team April 6, 2023 12:40
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review April 6, 2023 12:40
@Stefan-Ethernal Stefan-Ethernal removed the breaking change Functionality that contains breaking changes label Apr 7, 2023
@Stefan-Ethernal Stefan-Ethernal merged commit 5d4c9d9 into develop Apr 7, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-571-obsolete-block-time-from-server-cmd branch April 7, 2023 10:42
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@goran-ethernal goran-ethernal goran-ethernal approved these changes

@igorcrevar igorcrevar igorcrevar approved these changes

Assignees

@Stefan-Ethernal Stefan-Ethernal

Labels
feature New update to Polygon Edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Stefan-Ethernal @igorcrevar @goran-ethernal @flavor-town