Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

refactor(server): remove block time configuration from config and server params #1363

Conversation

flavor-town
Copy link
Contributor

Description

The block time configuration was removed from the raw config and server params.
The initBlockTime function was also removed from the server params.
polygon-edge server command was not doing anything with those values.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

… server params

The block time configuration was removed from the raw config and server params. The initBlockTime function was also removed from the server params.
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@flavor-town
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@Stefan-Ethernal Stefan-Ethernal requested a review from a team April 6, 2023 04:57
@Stefan-Ethernal
Copy link
Collaborator

Generally the problem we are currently facing is that server config (https://github.com/flavor-town/polygon-edge/blob/EVM-571/server/config.go#L27), that is used for providing syncer block time remains 0 with this change. Therefore we need to figure out a way to fetch block time from consensus parameters.

PolyBFTConfig already has such field, however not sure for IBFT.

@Stefan-Ethernal Stefan-Ethernal changed the base branch from develop to EVM-571-obsolete-block-time-from-server-cmd April 6, 2023 07:41
@Stefan-Ethernal Stefan-Ethernal merged commit c4784a7 into 0xPolygon:EVM-571-obsolete-block-time-from-server-cmd Apr 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants