Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes and improvements #15

Merged
merged 26 commits into from
Jul 16, 2023
Merged

Various fixes and improvements #15

merged 26 commits into from
Jul 16, 2023

Conversation

0x80
Copy link
Owner

@0x80 0x80 commented Jul 15, 2023 •
edited
Loading

Changes

  • Use relative paths for all dependency file links. This fixes an issue with nested dependencies using Yarn Shared package deep dependencies build wrong file:PATHs. #13.
  • Improve package manager detection logic.
  • Introduce usePackageManager to avoid passing it as an argument in many functions.
  • Update and improve the README.
  • Allow comments in the isolate.config.json file.
  • Make excludeLockfile true by default when using PNPM, so that no configuration is needed until we figure out how to mutate the lockfile.
  • Include the .npmrc file to the isolate output. This fixes a possible npm ci lockfile error for the Node 18 runtime.
  • Include the npm-shrinkwrap.json file instead of the lockfile if available.

Fixes #13
Closes #14
Fixes #9

@0x80 0x80 changed the title Use relative paths for file links and improve package manager detection Use relative paths for file links plus other small improvements Jul 15, 2023
@0x80 0x80 changed the title Use relative paths for file links plus other small improvements Use relative paths for file links plus other improvements Jul 15, 2023
@0x80 0x80 mentioned this pull request Jul 15, 2023
Closed
@0x80 0x80 marked this pull request as ready for review July 15, 2023 21:01
@0x80 0x80 changed the title Use relative paths for file links plus other improvements Various fixes and improvements Jul 16, 2023
@0x80 0x80 merged commit 609d287 into main Jul 16, 2023
@0x80 0x80 deleted the topic/0715-use-relative-paths branch December 18, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shared package deep dependencies build wrong file:PATHs. If workspaces is set to an object, we get a crash.
1 participant
@0x80