New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If workspaces is set to an object, we get a crash. #9

Closed

JoachimKoenigslieb opened this issue Jun 22, 2023 · 1 comment · Fixed by #15

JoachimKoenigslieb commented Jun 22, 2023

I have this object as my workspaces setting in my root package.json

"workspaces": { "packages": [ "apps/*", "packages/*" ], "nohoist": [ "**/ts-node" ] },

This causes an error on this line: https://github.com/0x80/isolate-package/blob/main/src/helpers/create-packages-registry.ts#L61, as flatMap is not defined on an object.

I have fixed my issue by providing it trough setting workspacePackages in the config manually. Thanks a lot for the project!

You rock!

The text was updated successfully, but these errors were encountered:

Owner

0x80 commented Jun 23, 2023 •

edited

Loading

Hi @JoachimKoenigslieb thanks for reporting, and for the kind words :) I will look into it, hopefully soon, but I'm traveling atm.

0x80 mentioned this issue

Various fixes and improvements #15

Merged

0x80 closed this as completed in #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment