Added ability to set the timeout of an HTTP request

[basicn86]

I've been developing a web scraper, however, the web scraper seems to get stuck on some random websites. Sometimes it just tries to download a massive file, other times the resource does not exist and it times out. So I added the ability to set the request timeout to prevent the scraper from being stalled for too long.

[JonathanMagnan]

Thank you @basicn86, for your contribution,

Look good, I will ask my developer to review it and release a version with it if he accepts the pull request.

Best Regards,

Jon

---

Sponsorship
Help us improve this library

Performance Libraries
context.BulkInsert(list, options => options.BatchSize = 1000);
Entity Framework Extensions • Dapper Plus

Runtime Evaluation
Eval.Execute("x + y", new {x = 1, y = 2}); // return 3
C# Eval Function

[elgonzo]

Why should an assignment like HtmlWeb.Timeout = -4567 be equivalent to HtmlWeb.Timeout = 0, and why and how would some HAP user possibly expect -4567 being the same as 0 for timeout values?

In my opinion it would rather make more sense to throw an ArgumentOutOfRangeException for TimeOut values less than or equal to zero except Timeout.Infinite (Timeout.Infinite is the value -1 which indicates inifinite timeout), equivalent to the behavior of HttpWebRequest.Timeout (rejecting negative values except Timeout.Infinite) and HttpClient.Timeout (rejecting TimeSpan values that are zero or less than zero except TimeSpan.Infinite).

[basicn86]

Good idea, I adjusted the setter to throw a ArgumentOutOfRangeException if the value is less than or equal to zero. Thanks!

[elgonzo]

Note that i edited my comment, as i originally did not account for Timeout.Infinite (which is the value -1)

So, basically, the setter should throw if value <= 0 && value != Timeout.Infinite.

(My apologies for this oversight in my original comment.)

[basicn86]

To be honest, I do not expect any users to be waiting infinitely for a document to load. The default value for HttpClient.Timeout and HttpWebRequest.Timeout is 100,000 ms, or 100 seconds. Adding an infinite timeout is a bit troublesome since HttpWebRequest requires an integer while HttpClient requires a Timespan object to be passed instead. I think throwing an exception if the value is zero or less is more of a practical approach.

[elgonzo]

Adding an infinite timeout is a bit troublesome since HttpWebRequest requires an integer while HttpClient requires a Timespan object to be passed instead.

No, it's actually not troublesome :-) because Timeout.InfiniteTimeSpan is per definition a TimeSpan value of -1 millisecond. ThereforeTimeSpan.FromMilliseconds(-1) (i.e., TimeSpan.FromMilliseconds(Timeout.Infinite)) equals Timeout.InfiniteTimeSpan. No special treatment necessary here, just pass the integer timeout value to TimeSpan.FromMilliseconds and Bob's your uncle...

[basicn86]

Oh really? I thought TimeSpan.FromMilliseconds(-1) would throw an exception that it's out of bounds. In this case, we can change that if statement to be this if (value <= 0 && value != -1) { throw new ArgumentOutOfRangeException(); } There you go, works as expected.

[JonathanMagnan]

Hello @basicn86 ,

The v1.11.49 has been released with your pull. Thank you for your contribution.

A big thank also to @elgonzo for reviewing and improving this pull ;)

Best Regards,

Jon