Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OptionOutputAsXml = true since version 1.11.65 crossorigin issue #569

Closed
EynsherKiel opened this issue Sep 9, 2024 · 2 comments
Closed
Assignees

Comments

@EynsherKiel
Copy link

EynsherKiel commented Sep 9, 2024

Hi there,

I work with xhtml and output as xml is an important feature

<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>

With OptionOutputAsXml in version 1.11.61 rendered to

<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin="" />

But in 1.11.65

<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin />

maybe it's a bug, I don't know, or maybe it should be like that, but xhml can't parse crossorigin without ="", exception message
Attribute name "crossorigin" associated with an element type "link" must be followed by the ' = ' character

@JonathanMagnan JonathanMagnan self-assigned this Sep 10, 2024
@JonathanMagnan
Copy link
Member

Hello @EynsherKiel ,

Thank you for reporting.

Indeed, that issue was recently added, I believe, to the v1.11.62. That change is currently causing many unexpected side effects (to the point that I wonder if I should not revert it).

I'm traveling until September 19; it will be fixed when I return.

Best Regards,

Jon

JonathanMagnan added a commit that referenced this issue Sep 22, 2024
@JonathanMagnan
Copy link
Member

Hello @EynsherKiel ,

A new version has been released today: https://github.com/zzzprojects/html-agility-pack/releases/tag/v1.11.66

While the fix is not 100% backward compatible with versions prior to v1.11.62 as this is now no longer possible to write an attribute without a quote, it will definitely fix this issue.

Let me know if your issue is fixed.

Best Regards,

Jon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants