url's in irc cut off on wrong character in drop-down-terminal

[rduivenvoorde]

to be honest I'm not sure if it IS a drop-down-terminal problem.
but I have a screen session on a remote server where I have irc running showing me github updates (#qgis on freenode)

if I connect to the screen session via ssh, I can ctrl-click on url's in the irc session like: http://hub.qgis.org/issues/9174#change-46831 and it will open my browser on that issue anchor. But in the drop down terminal ctrl-hovering or ctrl-clicking over the same url, the link stops at the # sign.

As said, I'm not a terminal-type guru. So maybe it is configuration related?

[aperezdc]

This is an issue with the regular expressions used to match URLs. If you edit terminal.js, around line 126, change this:

  { pattern: SchemePattern + "//(?:" + UserPassPattern + "\\@)?" + HostPattern + PortPattern + UrlPathPattern, flavor: UriFlavor.AsIs },

to this:

  { pattern: "(?:ftp|http)s?://[-a-zA-Z0-9.?$%&/=_~#.,:;+]*", flavor: UriFlavor.AsIs },

and the whole URL will be matched correctly.

(Coincidentally this is the URL match regexp I am using here.)

[Gottox]

Can you release a fixed version?

Thanks :)

[johanfleury]

Hi.

This is what I experienced:

• http://foo.example.net/bar.html - it stops at the end of bar and don't match .html.
• http://foo.example.net/_bar.html - it stops on _ and don't match _bar.html

[Gottox]

Same for me.