Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLs should be clickable #85

Closed
szarnyasg opened this issue Oct 25, 2020 · 1 comment
Closed

URLs should be clickable #85

szarnyasg opened this issue Oct 25, 2020 · 1 comment
Assignees
Labels

Comments

@szarnyasg
Copy link

Describe the bug
I'm curious how to make URLs clickable in Drop Down Terminal X.

To Reproduce
Steps to reproduce the behavior:

  1. Open Drop Down Terminal X
  2. Run echo https://github.com
  3. The resulting text should be clickable.

I believe the links in the terminal should be clickable. For comparison, using the GNOME terminal, the string https://github.com:

  • get underlined when hovered,
  • is clickable with the Ctrl key.

In Drop Down Terminal X, the link doesn't get underlined and isn't clickable.

Expected behavior
A clear and concise description of what you expected to happen.

Desktop (please complete the following information):

  • Distro: Fedora
  • Gnome-version: 3.36.7
  • Extension-version 16
  • Xorg or wayland: Wayland

Context
I'm not sure if this is currently supported by Drop Down Terminal X. I found a related issue for Drop Down Terminal and it seems the URL handling code is present in this repository as well:

const UrlPathPattern = '(?:(/' + UserCharsClassPattern + '+(?:[(]' + UserCharsClassPattern + '*[)])*' + UserCharsClassPattern + '*)*' + PathTermClassPattern + ')?';

@szarnyasg
Copy link
Author

I've upgraded to the code on master and it works now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants