Remove downloaded scripts and replace with CDN #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szpak
reviewed
Mar 6, 2023
|
Please leave an option to use the theme without a CDN. CDN are problematic from a privacy point of view, since they allow the CDN to track users across websites. |
* delicious and google bookmarks discontinued
* delicious and google bookmarks discontinued
* fix: i18n keys
* Social services i18n keys had "line" as a key, fixed accordingly.
* fix: added missing share services
Added "telegram" and "whatsapp" in the list.
* fix: breadcrumb not turning-off when in term list
When breadcrumb is turned-off in config file, it remains available in `/categories/{term}/` and `/tags/{term}/ ` list view.
* fix: breadcrumb not turning-off when set in config
Fixed breadcrumb showing in "Section List" regardless of "false" setting in config params.
* upd: deprecated in Hugo v0.119.0, removed in Hugo v0.125.0
* fix: use hugo.IsServer as .Site.IsServer is deprecated
---------
Co-authored-by: I'M YourOnly.One <[email protected]>
Co-authored-by: techmagus <[email protected]>
Co-authored-by: Yoni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think using an existing CDN than downloading a third-party script locally is a better approach. This makes the local repository smaller.