Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only enabled secrets #26

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Only enabled secrets #26

merged 2 commits into from
Sep 24, 2024

Conversation

melvinfolkers
Copy link
Member

No description provided.

@melvinfolkers
Copy link
Member Author

@TimvdHeijden can you review this one? I added a disabled secret in our test vault to reproduce the issue. you can run the test before and after to see it fixes the problem with disabled secrets not being listed.

image

closes #25

Copy link
Contributor

@TimvdHeijden TimvdHeijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TimvdHeijden TimvdHeijden merged commit 5a5d78a into main Sep 24, 2024
1 check passed
@TimvdHeijden TimvdHeijden deleted the only-enabled-secrets branch September 24, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when getting secrets from a keyvault when one secret is disabled
2 participants