Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing comment plugin not using user settings when overriding default setting #3424

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixing comment plugin not using user settings when overriding default setting #3424

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d40a952
Updating comment plugin option and fixing comment option reset bug
Neko-Box-Coder Aug 22, 2024
b4920fb
Added error message when using old comment option
Neko-Box-Coder Aug 22, 2024
7134d3f
Rewording error message for old comment option
Neko-Box-Coder Aug 22, 2024
5dc41ce
Fixing old comment option error message being spammed
Neko-Box-Coder Aug 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions runtime/plugins/comment/comment.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ ft["zsh"] = "# %s"

function updateCommentType(buf)
if buf.Settings["commenttype"] ~= nil then
micro.InfoBar():Error("\"commenttype\" option has been updated to \"comment.type\"",
"instead, please update accordingly")
micro.InfoBar():Error("\"commenttype\" option has been renamed to \"comment.type\"",
", please update your configuration")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After changing commenttype to comment.type in settings.json and running the reload command, micro still stubbornly shows this error.

end

-- NOTE: Don't use SetOptionNative() to set "comment.type",
Expand Down