nightly: Fix asset names with nightly
as version string
#3418
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized using
$VERSION
within the archive resp. asset name is counterproductive when used for thenightly
upload, because thesoftprops/action-gh-release
will only delete and update assets with the same name present.Having an updated from e.g.
2.0.14-dev.243
->2.0.14-dev.244
->2.0.14-dev.245
fills thenightly
"release" with all of the assets.The correction of the nightlies currently needs manual adjustment to be cleaned up.
So I suggest to slightly adapt the
tools/cross-compile.sh
again to allow a custom string as archive version, if given otherwise use the parsed version. Thenightly
action then can usetools/cross-compile.sh nightly
to provide fixed asset names, which will be properly handled by thesoftprops/action-gh-release
action.I wasn't able to find an option cleaning up all the assets present at one release.
Side note:
The SHA sum created for the nightlies is only valid till the next build will be done for the same version.