Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move to zwavejs 7 #864

Merged
merged 22 commits into from
Mar 24, 2021
Merged

feat: move to zwavejs 7 #864

merged 22 commits into from
Mar 24, 2021

Conversation

robertsLando
Copy link
Member

@robertsLando robertsLando commented Mar 10, 2021

Updated zwavejs to version 7

BREAKING CHANGE: Most changes are already documented here:

  • Corrected parsing of Node Information Frames (NIF), reworked node properties
  • No automatic query of all node values when restarting from cache, interview completed event is no longer emitted on startup
  • Reworked "notification" event, node notifications are mapped to mqtt using a different topic/payload
  • This version is incompatible with HA versions before 2021.4.x

@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧

I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧

I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧

I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧

I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧

I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

@coveralls
Copy link

coveralls commented Mar 10, 2021

Pull Request Test Coverage Report for Build 683801626

  • 0 of 122 (0.0%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 18.16%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/nodes-table/nodes-table.js 0 1 0.0%
lib/Gateway.js 0 8 0.0%
types/index.d.ts 0 14 0.0%
lib/ZwaveClient.js 0 99 0.0%
Files with Coverage Reduction New Missed Lines %
lib/Gateway.js 3 19.78%
Totals Coverage Status
Change from base Build 678785679: -0.05%
Covered Lines: 2027
Relevant Lines: 11447

💛 - Coveralls

@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧

I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧

I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧

I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

@jcam
Copy link
Contributor

jcam commented Mar 11, 2021

There is work required for the HA integration as well, this version will most likely not work. Might be useful to include a note in the breaking change list saying it is incompatible with HA versions before N, where N is likely 2021.4.x
(and since it doesn't have the updated server in it yet, because it hasn't been written yet, it probably is incompatible regardless)
Reference: home-assistant-libs/zwave-js-server-python#162

@robertsLando
Copy link
Member Author

@jcam Updated breaking changes list

@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧

I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

@raman325
Copy link
Contributor

zwave-js/zwave-js-server#165 was merged and zwave-js/zwave-js-server#167 is pending. Once that is merged, zwave-js-server should be backwards compatible although I am still testing that

@robertsLando robertsLando requested a review from AlCalzone March 24, 2021 08:13
lib/ZwaveClient.js Outdated Show resolved Hide resolved
lib/ZwaveClient.js Show resolved Hide resolved
@raman325
Copy link
Contributor

raman325 commented Mar 24, 2021

FYI zwave-js-server 1.3.0 was just released and it has zwave-js 7.0.0 support. That support is intended to be backwards compatible with previous releases of Home Assistant, so no breaking change notice should be required

@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧

I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

@robertsLando robertsLando changed the title feat: move to [email protected] feat: move to zwavejs 7 Mar 24, 2021
@robertsLando robertsLando merged commit 0bff7a7 into master Mar 24, 2021
@robertsLando robertsLando deleted the zwavejsv7 branch March 24, 2021 17:02
@raman325
Copy link
Contributor

@robertsLando I noticed that HA is still listed as a breaking change. See my comment here: #864 (comment) (edited after the fact)

@robertsLando
Copy link
Member Author

Sorry will remove that from release notes thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants