New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for node-zwave-js 7.0.0 via new server schema 3 #165

Merged

balloob merged 17 commits into zwave-js:master from raman325:schema_3

Mar 18, 2021

Collaborator

raman325 commented Mar 16, 2021 •

edited

Loading

Reference doc: home-assistant-libs/zwave-js-server-python#162

TODO:

translate protocolVersion into a version that would be recognized for schemas < 3
Handle notification event changes (The code has been updated but it does the same thing for all schema versions, and as mentioned in Discord, I think this will break the existing HA code)

raman325 changed the title ~~begin adding support for server schema 3 for node-zwave-js 7.0.0~~ Add support for node-zwave-js 7.0.0 via new server schema 3

balloob reviewed

View reviewed changes

src/lib/controller/message_handler.ts Outdated Show resolved Hide resolved

balloob reviewed

View reviewed changes

src/lib/state.ts Show resolved Hide resolved

balloob reviewed

View reviewed changes

src/lib/state.ts Outdated Show resolved Hide resolved

balloob reviewed

View reviewed changes

src/lib/state.ts Outdated Show resolved Hide resolved

balloob reviewed

View reviewed changes

src/lib/controller/incoming_message.ts Outdated Show resolved Hide resolved

raman325 force-pushed the schema_3 branch from 4fac813 to 77ec4bd Compare

March 17, 2021 03:17

raman325 added 12 commits

March 17, 2021 15:37


          begin adding support for server schema 3 for node-zwave-js 7.0.0

5f679c0


          some tweaks

0f4c2af


          tweaks

847dfea


          accept both spellings of controller removeNodeFromAllAssociations com…

…mand


          review feedback

070ec98


          update schema docs

16a951d


          handle notification event changes and return null fo isFrequentListen…

50fac18

…ing if it's undefined


          remove unused error

597239c


          use a single incoming message interface

bcf7cf6


          prettier

81780e3


          fix notification logic

4c9d753


          bump zwave-js to 7.0.0-beta1, use version 1 lock file, and handle ver…

471e6ef

…sion backwards compatibility

raman325 force-pushed the schema_3 branch from 0f14811 to 471e6ef Compare

March 17, 2021 19:37

raman325 marked this pull request as ready for review

March 17, 2021 19:37

raman325 added 3 commits

March 17, 2021 15:40


          remove unused param

377858f


          fixes

ba9a938


          refactor to reduce LOC

bd1dcaa

balloob reviewed

View reviewed changes

package.json Outdated Show resolved Hide resolved

balloob reviewed

View reviewed changes

src/lib/server.ts Show resolved Hide resolved

balloob approved these changes

View reviewed changes

raman325 added 2 commits

March 17, 2021 21:14


          bump zwave-js to 7.0.0-b1 in dev dependencies

3e67bec


          move ccId from args into event dictionary

b197a17

balloob merged commit ee5746f into zwave-js:master

raman325 mentioned this pull request

feat: move to zwavejs 7 zwave-js/zwave-js-ui#864

Merged

raman325 mentioned this pull request

Be explicit about types for states #276

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet