Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: better hass id and topics sanification #235

Closed
wants to merge 5 commits into from
Closed

fix: better hass id and topics sanification #235

wants to merge 5 commits into from

Conversation

robertsLando
Copy link
Member

Sanitize properties like Door/Window in topics and hass ids

@robertsLando robertsLando requested a review from varet80 January 14, 2021 10:12
@robertsLando
Copy link
Member Author

@billiaz Coudl you give this a try?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 485571155

  • 0 of 23 (0.0%) changed or added relevant lines in 2 files are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 23.608%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/MqttClient.js 0 9 0.0%
lib/Gateway.js 0 14 0.0%
Files with Coverage Reduction New Missed Lines %
lib/Gateway.js 8 18.95%
Totals Coverage Status
Change from base Build 484827662: -0.07%
Covered Lines: 1952
Relevant Lines: 8447
💛 - Coveralls

@robertsLando
Copy link
Member Author

merged in #247

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varet80 varet80 Awaiting requested review from varet80

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertsLando @coveralls