Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hass): added manual discovery setting #851

Merged
merged 5 commits into from
Mar 9, 2021
Merged

Conversation

robertsLando
Copy link
Member

With this setting discovery payload will not be sent on startup but users will be able to send them manually from the UI. Useful when using mqtt discovery paired with zwavejs integration to discovery only some entities. Fixes #819

With this setting discovery payload will not be sent on startup but users will be able to send them manually from the UI. Useful when using mqtt discovery paired with zwavejs integration to discovery only some entities. Fixes #819
@coveralls
Copy link

coveralls commented Mar 9, 2021

Pull Request Test Coverage Report for Build 635783111

  • 14 of 35 (40.0%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 18.38%

Changes Missing Coverage Covered Lines Changed/Added Lines %
types/index.d.ts 0 1 0.0%
app.js 0 8 0.0%
lib/Gateway.js 14 26 53.85%
Files with Coverage Reduction New Missed Lines %
lib/Gateway.js 3 19.97%
Totals Coverage Status
Change from base Build 635778937: 0.02%
Covered Lines: 2026
Relevant Lines: 11303

💛 - Coveralls

@robertsLando robertsLando requested a review from varet80 March 9, 2021 08:22
@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧

I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

@robertsLando robertsLando merged commit 255e9b3 into master Mar 9, 2021
@robertsLando robertsLando deleted the manual-discovery branch March 9, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Platform mqtt does not generate unique IDs. ID zwavejs2mqtt
2 participants