Adding Popp Radiator Valve TRV alternative ID #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 419384718
💛 - Coveralls |
|
@roflmao I plan to remove all climates from that file, at least the ones that can be auto discovered correctly from my algorithm. The Danfoss isn't discovered correctly because it has only one mode. Let me create a fix for it instead of merging this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Showing up as:
Popp Wireless Thermostatic Valve TRV
Device ID: 2-40976-277 (0x0002-0xa010-0x0115)
User values:
https://www.jottacloud.com/s/00637ed716ea942484c8e50a19cdee12baf
No climate auto discovery:
https://www.jottacloud.com/s/00650a8f7ae020b4481ba27f999f5590093