refactor: make nodes a map instead of an array #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zwaveclient nodes will be a Map nodeId -> node BREAKING CHANGE: `getNodes` function of client does return an array of only available nodes and the index doesn't match the actual nodeId, `refreshNeightbors` returns an map nodeId -> neighborns[] and node removed socketr event payload has changed
|
🚧 It seems like this PR has lint errors 🚧
I should be able to fix them for you. If you want me to, just comment |
AlCalzone
reviewed
Feb 23, 2021
AlCalzone
reviewed
Feb 23, 2021
AlCalzone
reviewed
Feb 23, 2021
3 tasks
|
🚧 It seems like this PR has lint errors 🚧
I should be able to fix them for you. If you want me to, just comment |
Pull Request Test Coverage Report for Build 596496808
💛 - Coveralls |
Renamed to `setNodeName` and `setNodeLocation` as now them also try to store the value to driver
|
🚧 It seems like this PR has lint errors 🚧
I should be able to fix them for you. If you want me to, just comment |
|
🚧 It seems like this PR has lint errors 🚧
I should be able to fix them for you. If you want me to, just comment |
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZwaveClient
nodesis now a Map nodeId -> nodeBREAKING CHANGE:
getNodesfunction of ZwaveClient returns an array of available nodes but the index doesn't match the nodeIdrefreshNeighboursreturns a map nodeId -> neighbours[]node removed socket event now returns the node removed
renamed
setNodeNameandsetNodeLocationapis (removed the leading_) as now them also store the value to controller