-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: fixed dockerfile and dockerfile.contrib to use node:erbium-buster-slim #666
Conversation
dependabot reverted the base image to alpine this PR changes it back to node:erbium-buster-slim
Pull Request Test Coverage Report for Build 585772392
💛 - Coveralls |
@jcam erbium-buster-slim is failing on the build check
the github workflow expects options:
I assume option 2 would break anyone relying on the v6 version we currently publish? unless that uses a different workflow? |
What workflow is running the dockerfile.contrib? |
the regular Dockerfile should be using node alpine |
reverted dockerfile to 15.9.0-alpine
ok will revert the changes to that file, why the difference? |
contrib does a lot more :D |
if you use slim up top, you'll need to run an apt-get install a few things... build-essential, git, jq... i think that's all |
I put it back to alpine for the dockerfile but to erbirum-buster-slim (to mirror your change that got wiped away) for the .contrib file, i had (wrongly) assumed that both edits by the dependabot was bad.
|
change git clone section to use erbium-buster not erbium-buster-slim
change buster-slim to buster
put slim back after testing
dependabot changed all references to to
node:erbium-buster-slim
tonode:15.9.0-alpine
.This PR reverts those changes.,