Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): authentication #591

Merged
merged 49 commits into from
Feb 18, 2021
Merged

feat(ui): authentication #591

merged 49 commits into from
Feb 18, 2021

Conversation

robertsLando
Copy link
Member

@robertsLando robertsLando commented Feb 15, 2021

Fixes #505

Default credentials:

Username: admin
Passowrd: zwave

Preview:

Schermata da 2021-02-17 09-51-56

@robertsLando
Copy link
Member Author

@jarrettv would you like to add some of your magic to the login/error pages?

@coveralls
Copy link

coveralls commented Feb 15, 2021

Pull Request Test Coverage Report for Build 577414584

  • 7 of 592 (1.18%) changed or added relevant lines in 8 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.8%) to 18.765%

Changes Missing Coverage Covered Lines Changed/Added Lines %
config/store.js 0 2 0.0%
lib/SocketManager.js 2 11 18.18%
src/store/mutations.js 0 16 0.0%
lib/utils.js 1 25 4.0%
src/apis/ConfigApis.js 0 78 0.0%
src/router/index.js 0 135 0.0%
app.js 0 321 0.0%
Files with Coverage Reduction New Missed Lines %
config/store.js 1 0%
lib/utils.js 1 42.29%
Totals Coverage Status
Change from base Build 577365467: -0.8%
Covered Lines: 2009
Relevant Lines: 10978

💛 - Coveralls

@chrisns
Copy link
Member

chrisns commented Feb 15, 2021

you're encrypting the passwords which is interesting, but the key material is stored along with the payload so i'm not sure what you're gaining, meanwhile you're not hashing and salting.

you're also exposing when a user doesn't exist

@chrisns chrisns marked this pull request as draft February 15, 2021 21:34
app.js Outdated Show resolved Hide resolved
app.js Show resolved Hide resolved
app.js Outdated Show resolved Hide resolved
app.js Outdated Show resolved Hide resolved
app.js Outdated Show resolved Hide resolved
app.js Outdated Show resolved Hide resolved
app.js Outdated Show resolved Hide resolved
docs/guide/env-vars.md Show resolved Hide resolved
src/App.vue Show resolved Hide resolved
src/App.vue Outdated Show resolved Hide resolved
@robertsLando robertsLando marked this pull request as ready for review February 16, 2021 16:43
@robertsLando robertsLando requested a review from chrisns February 16, 2021 16:43
@robertsLando
Copy link
Member Author

@chrisns Do you think we are done here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] Frontend Authentication
3 participants