-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): compact control panel menu #524
Conversation
🚧 It seems like this PR has lint errors 🚧 |
Wow, this is awesome! Please @ahochsteger Look at this |
I'm thinking about keep both control panel visualizations, let's call the second one |
Pull Request Test Coverage Report for Build 657713677
💛 - Coveralls |
Really impressed, I like this new grid view and appreciate the "group by" option. Some people may prefer the current list view, would it be feasible to have an option to switch back and forth? |
@jarrettv wow I'm totally impressed by this beautiful looking UI - very good work! @robertsLando seems like I have to reconsider some of my plans, but I think the refactoring of Since both UIs seem to have different strengths I see no problem in providing both UIs (until we may combine these into one if possible), ideally backed by What do you think? |
Yep I think the same, I think that some users could find the table more clear others could prefer @jarrettv, if we allow to switch from one to the other esily (and store the preference in settings like for the table settings etc) it would be awesome! I think Jarret version could be the default one on mobiles |
Yes, that sounds good. We may see them as the "simple UI" with most every-day features and the "advanced UI" with all available features. |
I agree! |
…avejs2mqtt into feat-compact-cp-menu
🚧 It seems like this PR has lint errors 🚧 |
🚧 It seems like this PR has lint errors 🚧 |
🚧 It seems like this PR has lint errors 🚧 |
…o feat-compact-cp-menu
🚧 It seems like this PR has lint errors 🚧
I should be able to fix them for you. If you want me to, just comment |
This pull-request is stale because it has been open 90 days with no activity. Remove the stale label or comment or this will be closed in 5 days. To ignore this pull-request entirely you can add the no-stale label |
This pull-request is now closed due to inactivity, you can of course reopen or reference this pull-request if you see fit. |
No description provided.