Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): compact control panel menu #524

Closed
wants to merge 36 commits into from
Closed

Conversation

robertsLando
Copy link
Member

No description provided.

@robertsLando robertsLando marked this pull request as ready for review February 9, 2021 10:42
@robertsLando robertsLando marked this pull request as draft February 9, 2021 10:42
@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧
I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

@robertsLando
Copy link
Member Author

Wow, this is awesome! Please @ahochsteger Look at this

@robertsLando
Copy link
Member Author

I'm thinking about keep both control panel visualizations, let's call the second one ControlPanelLite and add a switch to see one or the other. I think that the lite version is perfect for mobile devices and could be anabled by default on lower sceen size screens

@coveralls
Copy link

coveralls commented Feb 9, 2021

Pull Request Test Coverage Report for Build 657713677

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 18.201%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/router/index.js 0 3 0.0%
Totals Coverage Status
Change from base Build 657712063: -0.002%
Covered Lines: 2025
Relevant Lines: 11410

💛 - Coveralls

@towerhand
Copy link
Contributor

Really impressed, I like this new grid view and appreciate the "group by" option. Some people may prefer the current list view, would it be feasible to have an option to switch back and forth?

@ahochsteger
Copy link
Collaborator

@jarrettv wow I'm totally impressed by this beautiful looking UI - very good work!

@robertsLando seems like I have to reconsider some of my plans, but I think the refactoring of ManagedItems that has been merged today may also be used to provide the node data with filtering, grouping and sorting functionality for this UI.

Since both UIs seem to have different strengths I see no problem in providing both UIs (until we may combine these into one if possible), ideally backed by ManagedItems to provide cross-UI functionality (filtering, grouping, sorting, ...), which may also be used by the new mesh graph.

What do you think?

@robertsLando
Copy link
Member Author

Yep I think the same, I think that some users could find the table more clear others could prefer @jarrettv, if we allow to switch from one to the other esily (and store the preference in settings like for the table settings etc) it would be awesome!

I think Jarret version could be the default one on mobiles

@ahochsteger
Copy link
Collaborator

I think Jarret version could be the default one on mobiles

Yes, that sounds good.

We may see them as the "simple UI" with most every-day features and the "advanced UI" with all available features.
I can also imagine the simple UI by default for new users in the future - at least when all important features are there.

@robertsLando
Copy link
Member Author

We may see them as the "simple UI" with most every-day features and the "advanced UI" with all available features.
I can also imagine the simple UI by default for new users in the future - at least when all important features are there.

I agree!

@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧
I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧
I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧
I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧

I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

@github-actions
Copy link
Contributor

This pull-request is stale because it has been open 90 days with no activity. Remove the stale label or comment or this will be closed in 5 days. To ignore this pull-request entirely you can add the no-stale label

@github-actions github-actions bot added the Stale label Jun 15, 2021
@github-actions
Copy link
Contributor

This pull-request is now closed due to inactivity, you can of course reopen or reference this pull-request if you see fit.

@github-actions github-actions bot closed this Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants