Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile with debian buster/remote branch support #41

Closed
wants to merge 1 commit into from

Conversation

roflmao
Copy link

@roflmao roflmao commented Dec 1, 2020

Inspired by #28 i created a seperate Dockerfile for building directly from a branch configurable with docker build --build-args:

$ docker build --build-arg Z2M_BRANCH=feat#startStop --build-arg ZWJS_BRANCH=master --no-cache -t zwavejs2mqtt:startStop -f docker/Dockerfile.contrib.master .

It also uses latest debian stable (buster).

@coveralls
Copy link

Pull Request Test Coverage Report for Build 393641739

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 28.785%

Totals Coverage Status
Change from base Build 393291034: 0.0%
Covered Lines: 1827
Relevant Lines: 6474

💛 - Coveralls

@roflmao roflmao marked this pull request as ready for review December 1, 2020 13:34
@roflmao
Copy link
Author

roflmao commented Dec 1, 2020

It will build both zwavejs2mqtt/node-zwave-js from master if no build args defined.

@robertsLando
Copy link
Member

@roflmao Seems like a duplicate of the other Dockerfile, I know it's a little different but I cannot keep both

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants