feat(ui): show association error in association dialog #3802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9854501189Details
💛 - Coveralls |
AlCalzone
requested changes
Jul 9, 2024
Comment on lines
+193
to
+206
| allowedAssociation() { | ||
| const mainNode = this.node | ||
| const targetNode = this.group.target | ||
|
|
||
| if (!mainNode || !targetNode) { | ||
| return true | ||
| } | ||
|
|
||
| if (mainNode.security !== targetNode.security) { | ||
| return `Association not allowed, "${targetNode._name}" security is different from "${mainNode._name}"` | ||
| } | ||
|
|
||
| return true | ||
| }, |
There was a problem hiding this comment.
No, use Controller.checkAssociation to figure out if the association is allowed and if not, why not. Then display a different message for each reason.
There was a problem hiding this comment.
The screenshot in the issue was just one example.
There was a problem hiding this comment.
Is that actually exported from safe somewhere? Also is that only available in v13?
There was a problem hiding this comment.
The idea is to make a backend api call, the backend calls driver.controller.checkAssociation and passes the result back.
This requires v13 because the method and AssociationCheckResult was only added there.
|
Supersided by #3804 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3801