Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix arm build #3790

Merged
merged 6 commits into from
Jul 9, 2024
Merged

chore: fix arm build #3790

merged 6 commits into from
Jul 9, 2024

Conversation

robertsLando
Copy link
Member

@robertsLando robertsLando commented Jul 2, 2024 •
edited
Loading

Fixes #3795

@coveralls
Copy link

coveralls commented Jul 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9757924538

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 21.08%
Totals Coverage Status
Change from base Build 9682379330: 0.0%
Covered Lines: 3899
Relevant Lines: 19672
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9758396967

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 21.08%
Totals Coverage Status
Change from base Build 9682379330: 0.0%
Covered Lines: 3899
Relevant Lines: 19672
💛 - Coveralls

@robertsLando robertsLando mentioned this pull request Jul 4, 2024
Closed
uronito
uronito approved these changes Jul 4, 2024
View reviewed changes
Copy link

@uronito uronito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

epideme
epideme approved these changes Jul 8, 2024
View reviewed changes
Copy link

@epideme epideme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.

@robertsLando
Copy link
Member Author

Guys I know it looks ok but the underlying issue is still not fixed

@coveralls
Copy link

coveralls commented Jul 9, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9854873953

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 21.08%
Totals Coverage Status
Change from base Build 9682379330: 0.0%
Covered Lines: 3899
Relevant Lines: 19672
💛 - Coveralls

@robertsLando robertsLando merged commit ae39514 into master Jul 9, 2024
10 checks passed
@robertsLando robertsLando deleted the fix-arm-build branch July 9, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uronito uronito uronito approved these changes

@epideme epideme epideme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No arm64 release?
4 participants
@robertsLando @coveralls @epideme @uronito