-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: meterType devices missing ccSpecific values #35
Conversation
Pull Request Test Coverage Report for Build 387567036
💛 - Coveralls |
I am trying to fix hass discovery for multilevel sensors of temperature the hass payload is:
The payload is:
I think i always knew this is it:
Patch:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat: bind target values to current * feat(wip): hass discovery * fix: better discovery support * fix: hass socket apis * fix: alarmType and meterType mapping * fix: use commandClasses instead of hardCoded numbers * refactor: better docs on methods * fix: converted some values in hass devices.js * fix: converted some more values in devices.js * feat: skip discovety flag * fix: lint issues * fix: ignore discovery * fix: converted some more valueIds of devices.json * fix: lint issues * fix: push target value in values * fix: mode_map and fan _mode_map * fix: allow empty json device * fix: added ccSpecific to value meta * fix: setpoints valueIds * fix: commandclasses import * fix: set defaiult endpoint to 0 * feat: added ccSpecific * fix: undefined in num2hex * fix: use 5.4.1-alpha.0 * fix: probably fix to map template bug * fix: mode_map template creation * fix: added brackets to keys * fix: added comments * fix: getMappedValuesTemplate check type of value * fix: lint errors * docs: fixed hass docs * docs: migration and why zwavejs * docs: bitmask and color values * fix: lint issues * docs: fix for review * fix: typo * fix: lint on readme * docs: fix * docs: added some points to why zwavejs section * fix: payload parse of modes when discovery is enabled * fix: missing ccSpecific values (#35) * fix: binary sensors, units and undefined labels (#36) * fix: lint issues Co-authored-by: V Aretakis <[email protected]>
When a Command Class is type Meter. In some cases is not a sensor. This metric is a Delta in time, or reset parameter for the Sensor.
There Parameters miss the ccSpecific values, which sets the type of sensor. This change fixes this error