Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly parse notification #170

Merged
merged 5 commits into from
Jan 12, 2021
Merged

fix: correctly parse notification #170

merged 5 commits into from
Jan 12, 2021

Conversation

robertsLando
Copy link
Member

@robertsLando robertsLando requested a review from AlCalzone January 7, 2021 14:45
@coveralls
Copy link

coveralls commented Jan 7, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 480684478

  • 0 of 34 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 24.171%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/ZwaveClient.js 0 34 0.0%
Totals Coverage Status
Change from base Build 480679617: -0.09%
Covered Lines: 1963
Relevant Lines: 8297
💛 - Coveralls

@robertsLando robertsLando merged commit af41778 into master Jan 12, 2021
@robertsLando robertsLando deleted the fixNotification branch January 12, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlCalzone AlCalzone Awaiting requested review from AlCalzone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

onNotification does not handle all parameter types correctly
2 participants
@robertsLando @coveralls