Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: read only list values in UI and better logging #102

Merged
merged 4 commits into from
Dec 22, 2020
Merged

fix: read only list values in UI and better logging #102

merged 4 commits into from
Dec 22, 2020

Conversation

robertsLando
Copy link
Member

FIxes #101

@robertsLando robertsLando mentioned this pull request Dec 21, 2020
Closed
@coveralls
Copy link

coveralls commented Dec 21, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 438126049

  • 0 of 6 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.008%) to 28.535%
Changes Missing Coverage Covered Lines Changed/Added Lines %
app.js 0 1 0.0%
lib/ZwaveClient.js 0 5 0.0%
Totals Coverage Status
Change from base Build 438089044: -0.008%
Covered Lines: 1937
Relevant Lines: 6932
💛 - Coveralls

@robertsLando robertsLando changed the title fix: undefined values fix: read only list values in ui and better logging Dec 22, 2020
@robertsLando robertsLando changed the title fix: read only list values in ui and better logging fix: read only list values in UI and better logging Dec 22, 2020
@robertsLando robertsLando merged commit 03f5610 into master Dec 22, 2020
@robertsLando robertsLando deleted the fix#101 branch December 22, 2020 13:34
ahochsteger pushed a commit that referenced this pull request Dec 27, 2020
@robertsLando @ahochsteger
fix: read only list values in UI and better logging (#102)
5af038c 
* fix: undefined values

* fix: add more logging

* fix(ui): show read only list values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] UI doesn't show some states in lists values
2 participants
@robertsLando @coveralls