Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] store directory env var #85

Closed
jmgiaever opened this issue Dec 18, 2020 · 14 comments · Fixed by #308
Closed

[feat] store directory env var #85

jmgiaever opened this issue Dec 18, 2020 · 14 comments · Fixed by #308
Assignees
@robertsLando
Labels
enhancement New feature or request

Comments

@jmgiaever
Copy link
Contributor

How to change the path where the store-data is stored?
@jmgiaever jmgiaever added the question Further information is requested label Dec 18, 2020
@robertsLando
Copy link
Member

Why would you need this?

@jmgiaever
Copy link
Contributor Author

jmgiaever commented Dec 18, 2020 via email

@robertsLando
Copy link
Member

@jmgiaever You could create a symlink ?

@jmgiaever
Copy link
Contributor Author

jmgiaever commented Dec 18, 2020 via email

@robertsLando
Copy link
Member

@jmgiaever I could make it configurable using env vars. Would it be ok for you?

@robertsLando
Copy link
Member

It comes from: https://github.com/zwave-js/zwavejs2mqtt/blob/master/config/app.js#L4

@jmgiaever
Copy link
Contributor Author

@jmgiaever I could make it configurable using env vars. Would it be ok for you?

That would be perfectly fine :D Highly appreciated! :)

@robertsLando robertsLando added enhancement New feature or request and removed question Further information is requested labels Dec 21, 2020
@robertsLando robertsLando changed the title [question] How to change the store directory? [feat] store directory env var Dec 21, 2020
robertsLando added a commit that referenced this issue Jan 21, 2021
@robertsLando
feat: STORE_DIR env var and renamed OZW_NETWORK_KEY to NETWORK_KEY
b81219a 
Fixes #85
@robertsLando robertsLando mentioned this issue Jan 21, 2021
Merged
@robertsLando
Copy link
Member

@jmgiaever Sorry for the delay in this, there is an open PR ready :)

robertsLando added a commit that referenced this issue Jan 21, 2021
@robertsLando
feat: env var STORE_DIR and renamed OZW_NETWORK_KEY to NETWORK_KEY (#308
58c2cb9 
)

* feat: STORE_DIR env var and renamed OZW_NETWORK_KEY to NETWORK_KEY

Fixes #85

* fix: utils

* refactor: added jsdocs to utils

* fix: removeSlash is not a function

* fix: broken jsonStore tests

* fix: lint errors

* docs: env vars
@jmgiaever
Copy link
Contributor Author

Thank you! 👍 Appriciated!

@jmgiaever
Copy link
Contributor Author

@robertsLando PS! The snap package is now live: https://community.home-assistant.io/t/zwavejs2mqtt-snap-package/278994 / https://snapcraft.io/zwavejs2mqtt

@robertsLando
Copy link
Member

Thanks @jmgiaever ! If you would like to add it to docs feel free to open a PR :)

@jmgiaever
Copy link
Contributor Author

Thanks, I will. Just want to run it for some days, and fix the env.vars in the configuration script.

I also read that zwavejs is pulling device configuration, so I need to find out a solution on how I can make that directory readable in this confined environment. Do you happen to know if this is the only file zwave-js is writing to? Maybe @AlCalzone knows?

@AlCalzone
Copy link
Member

AlCalzone commented Feb 11, 2021 •
edited
Loading

The configs come from node_modules/@zwave-js/config/config. That directory and it's sub dirs must be writable.

@jmgiaever
Copy link
Contributor Author

Noted and fixed! Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robertsLando robertsLando

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: env var STORE_DIR and renamed OZW_NETWORK_KEY to NETWORK_KEY zwave-js/zwave-js-ui
3 participants
@jmgiaever @robertsLando @AlCalzone