-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shutter recognized as dimmer #3862
Comments
Hi @zeev-mindali , the code that defines if discovering a cover or a light dimmer is here: zwave-js-ui/api/lib/Gateway.ts Line 1254 in cfcde4a
I may have to add a case to handle your device as a cover, could you do a node export from the ui so I can check the |
Dear robert, i attaching two files: zeev |
Oh ok I may have understand what's the issue here, seems I only get the device class of root endpoint instead of getting it for each one, this requires a fix on my side |
hi @robertsLando |
@zeev-mindali The PR is not merged yet, how did you test it? |
I have created 9.18.1 relese, give it a try |
great, i will check it today, tnx a lot |
dear @robertsLando, i using HAOS |
I think that's something related to HA but I'm not an HA expert, try to ask to them and let me know :) |
@robertsLando but i have another device, whice is still shown as dimmer :( |
here the files: |
From discovery prospecctive seems good:
Then light dimmers:
|
this is my problem, the wallwand is not a dimmer, it's a cover :( |
@zeev-mindali the wallwand has multiple endpoints (13), could you do another export of the node please like you did here: #3862 (comment) ? |
here are logs, i attached only the wallwand |
@zeev-mindali those are the logs, I need an export of the node like you did hre: #3862 (comment) |
@zeev-mindali are ALL dimmers above covers? Because some are reporting |
the controller have two multi level switch:
|
@zeev-mindali wait for 9.19.1, will release it the end of the week |
Dear @robertsLando , any news on the release? |
for getting up or position: for getting down or position: the problem is in: it should be: if you need any more data , don't hasitate to ask for |
@zeev-mindali I need the discovery payload, the one you find by going to home assistant tab when you click on a node on control panel table, then select the cover in the list of discovery devices and you will see the discovery payload on the right that's the one sent to HA |
for an endpoint 8 {
"type": "cover",
"object_id": "position_8",
"discovery_payload": {
"command_topic": "zwave/mbr/gp9/switch_multilevel/endpoint_8/targetValue/set",
"position_topic": "zwave/mbr/gp9/switch_multilevel/endpoint_8/currentValue",
"set_position_topic": "zwave/mbr/gp9/switch_multilevel/endpoint_8/targetValue/set",
"position_template": "{{ value_json.value | round(0) }}",
"position_open": 99,
"position_closed": 0,
"payload_open": 99,
"payload_close": 0,
"availability": [
{
"payload_available": "true",
"payload_not_available": "false",
"topic": "zwave/mbr/gp9/status",
"value_template": "{{'true' if value_json.value else 'false'}}"
},
{
"topic": "zwave/_CLIENTS/ZWAVE_GATEWAY-zwave/status",
"value_template": "{{'online' if value_json.value else 'offline'}}"
},
{
"payload_available": "true",
"payload_not_available": "false",
"topic": "zwave/driver/status"
}
],
"availability_mode": "all",
"device": {
"identifiers": [
"zwavejs2mqtt_0xeeea28a4_node8"
],
"manufacturer": "TouchWand Co., Ltd.",
"model": "Glass 9 (Glass9)",
"name": "mbr-gp9",
"sw_version": "4.13.8"
},
"name": "mbr-gp9_position_8",
"unique_id": "zwavejs2mqtt_0xeeea28a4_8-38-8-currentValue"
},
"discoveryTopic": "cover/mbr-gp9/position_8/config",
"values": [
"38-8-currentValue",
"38-8-targetValue"
],
"persistent": false,
"ignoreDiscovery": false,
"id": "cover_position_8"
} |
i have for endpoint 8 two entity the second is switch: {
"type": "switch",
"object_id": "switch_8",
"discovery_payload": {
"payload_off": false,
"payload_on": true,
"value_template": "{{ value_json.value }}",
"command_topic": "zwave/mbr/gp9/switch_binary/endpoint_8/targetValue/set",
"state_topic": "zwave/mbr/gp9/switch_binary/endpoint_8/currentValue",
"availability": [
{
"payload_available": "true",
"payload_not_available": "false",
"topic": "zwave/mbr/gp9/status",
"value_template": "{{'true' if value_json.value else 'false'}}"
},
{
"topic": "zwave/_CLIENTS/ZWAVE_GATEWAY-zwave/status",
"value_template": "{{'online' if value_json.value else 'offline'}}"
},
{
"payload_available": "true",
"payload_not_available": "false",
"topic": "zwave/driver/status"
}
],
"availability_mode": "all",
"device": {
"identifiers": [
"zwavejs2mqtt_0xeeea28a4_node8"
],
"manufacturer": "TouchWand Co., Ltd.",
"model": "Glass 9 (Glass9)",
"name": "mbr-gp9",
"sw_version": "4.13.8"
},
"name": "mbr-gp9_switch_8",
"unique_id": "zwavejs2mqtt_0xeeea28a4_8-37-8-currentValue"
},
"discoveryTopic": "switch/mbr-gp9/switch_8/config",
"values": [
"37-8-currentValue",
"37-8-targetValue"
],
"persistent": false,
"ignoreDiscovery": false,
"id": "switch_switch_8"
} maybe the solution will be from this side. |
What does the switch do? Open & close? Is this a standard for covers to also have a binary switch to open/close or something only related to yours? |
nope, you correct |
the more i digging into it, the command topic is the one we need, you totally correct. |
@zeev-mindali yeah but this is the problem here, |
i agree with you, i played with the mqtt configuration in the home assistant. in both cases the only solution is Up/Down set to false, but after the expriance from the glass9 i not sure if needed only up or down, or both for using that. still playing with it |
@zeev-mindali let me know if there is something I can do on my side |
i very confused , i have a simple shutter also from mco home, which works great. it's payload: |
@zeev-mindali Sincerly I have no clue, I'm sorry :( |
found the problem, finally when i use the payload_stop or any other this is not correct it should be: i tested the zwave js ui, and it's working and sending the correct command, the issue is with mqtt or HA which not using the correct methods. if it's help, i can send you a zniffer log, for not working and working |
Can this be a fix? #3916 BTW I'm not sure if that could create some issue |
i saw in the gateway file, referance for open and close, didn't see a zwave command for stop, or i missed that? if there is a zwave-js-ui file i can test it and approve or disapprove |
does the fix is in the new release? |
mange to fix the code :) if (payload === 'STOP') { and the stop from ha is now working :) i checking now with the wallwand (needs to works also) and a single shutter MCO Home C621. |
tested with 3 diffrent devices, two has multi endpoint and one is shutter. and add to the begining of the function the code: this will fix the issues with the stop i tried to compile to arm v7 , but it's says the package will work only on macos :( so if you can also help with that also, i can check with the package |
sent you the suggested change |
Just submitted a change to #3916, could you check it? Only stop should be handled so? |
only stop should be handled, but if it's found in payload STOP then it should be false and not true this._zwave |
@zeev-mindali Ok will change the payload to be |
it doesn't matter if it's up->false or down->false, on both cases it will stop the cover. |
Ok perfect thanks for the feedback, merging now, patch release will come in next days |
great, |
@zeev-mindali You will find it on workflow assets once this ends: https://github.com/zwave-js/zwave-js-ui/actions/runs/11108825157 |
the 9.21.1 fixed the problem with start stop issue :) |
Dear all,
i connected the homeassistant to zwave-js-ui.
made working with mqtt discovery because of issues that the shutter is recognized as dimmier
once i made the choice i can see home assistant option on the device.
but the device reporting also as dimmer:
{
"type": "light",
"object_id": "dimmer_9",
"discovery_payload": {
"command_topic": "zwave/lab/gp9/switch_multilevel/endpoint_9/targetValue/set",
"state_topic": "zwave/lab/gp9/switch_multilevel/endpoint_9/currentValue",
"state_value_template": "{{ "OFF" if value_json.value == 0 else "ON" }}",
"brightness_command_topic": "zwave/lab/gp9/switch_multilevel/endpoint_9/targetValue/set",
"brightness_scale": 99,
"brightness_state_topic": "zwave/lab/gp9/switch_multilevel/endpoint_9/currentValue",
"brightness_value_template": "{{ value_json.value }}",
"on_command_type": "brightness",
"availability": [
{
"payload_available": "true",
"payload_not_available": "false",
"topic": "zwave/lab/gp9/status",
"value_template": "{{'true' if value_json.value else 'false'}}"
},
{
"topic": "zwave/_CLIENTS/ZWAVE_GATEWAY-zwave-js-ui/status",
"value_template": "{{'online' if value_json.value else 'offline'}}"
},
{
"payload_available": "true",
"payload_not_available": "false",
"topic": "zwave/driver/status"
}
],
"availability_mode": "all",
"device": {
"identifiers": [
"zwavejs2mqtt_0xf2e08abf_node48"
],
"manufacturer": "TouchWand Co., Ltd.",
"model": "Glass 9 v2.03 (Glass9)",
"name": "lab-gp9",
"sw_version": "4.13.8"
},
"name": "lab-gp9_dimmer_9",
"unique_id": "zwavejs2mqtt_0xf2e08abf_48-38-9-currentValue"
},
"discoveryTopic": "light/lab-gp9/dimmer_9/config",
"values": [
"38-9-currentValue",
"38-9-targetValue"
],
"persistent": false,
"ignoreDiscovery": false,
"id": "light_dimmer_9"
}
is there anything i can do to make it work as shutter?
are there any automation for making all dimmer recognized as shutter?
zeev
The text was updated successfully, but these errors were encountered: