Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart Start Screen Data Inconsistencies #3674

Closed
3 tasks done
zackbcom opened this issue Apr 20, 2024 · 6 comments · Fixed by #3684
Closed
3 tasks done

Smart Start Screen Data Inconsistencies #3674

zackbcom opened this issue Apr 20, 2024 · 6 comments · Fixed by #3684
Labels
enhancement New feature or request

Comments

@zackbcom
Copy link
Contributor

zackbcom commented Apr 20, 2024

Checklist

  • I am not using Home Assistant. Or: a developer has told me to come here.
  • I have checked the troubleshooting section and my problem is not described there.
  • I have read the changelog and my problem is not mentioned there.

Deploy method

Docker

Z-Wave JS UI version

9.11.1.9e7d24e

ZwaveJS version

12.5.5

Describe the bug

edit2: view the below comment from @robertsLando on changes: #3674 (comment)

edit: After looking at the code, I think this is the intended behavior. disable check

After upgrade from 9.9.1 to 9.11.1, the smart start screen has an issue loading all of the edit buttons, check boxes, protocol toggles.

image

To Reproduce

Have smart start items.
Upgrade docker from 9.9.1 to 9.11.1.
Unsure if it's some edge case from my personal Smart Start items.

Expected behavior

Shows all edit buttons, able to check all boxes, able to toggle the protocols.

Additional context

Looks like the items upgraded correctly with the recent updates
from

{
"k": "controller.provisioningList",
    "v": [
        {
            //...
            "supportedProtocols": [
                0,
                1
            ],
            //...
        }
    ]
}

to

{
"k": "controller.provisioningList",
    "v": [
        {
            //...
            "supportedProtocols": [
                "ZWave",
                "ZWaveLongRange"
            ],
            //...
        }
    ]
}
@zackbcom zackbcom added the bug Something isn't working label Apr 20, 2024
@zackbcom
Copy link
Contributor Author

@AlCalzone I'm unsure if this is UI specific.

@AlCalzone
Copy link
Member

AlCalzone commented Apr 20, 2024

The ones that are already included (have a node id in the first column) cannot be edited anymore, since the edit will have no effect until it's excluded and included again.

It might make sense to make this more obvious, e.g. group them by inclusion state.

@zackbcom
Copy link
Contributor Author

Agree, I submitted this because I thought the editing ended at the 2nd checkbox (second arrow) like it had some parsing issue with the rest of the data.

My use case for Smart Start screen is to keep a list of all my of my zwave devices and give them a name specific to the DSK.
For some devices I have to search using it's DSK to know what device it is and rename it. Like Water Sensors, door sensors, external plugs. I move these around some times and change all batteries or upgrade firmware with a plug in battery for coin cell.

Having to locate DSK row, then locate node id, then go to control panel and rename is a bit longer. But probably less work than update both sections.

Maybe we can have a button to:

  • navigate to the Control Panel and go the the specific node and open the node details.
  • or pop up a modal for the linked node on the Smart Start Screen.

@zackbcom
Copy link
Contributor Author

For the additional Info we could have a collapsible header above the table to give some more context around how the table manages it's data, and what the actions do, Zwave Button, Active, Check boxes, etc

maybe something like this, but a bit cleaner
image

@robertsLando robertsLando added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Apr 22, 2024
@robertsLando
Copy link
Member

robertsLando commented Apr 22, 2024

Basically:

About the info table I would like to ask @AlCalzone whaty could make sense in his opinion to add there, maybe also a mention to Long range would be good as they can only be added from there?

@robertsLando robertsLando removed the bug Something isn't working label Apr 22, 2024
@zackbcom zackbcom changed the title Smart Start Screen issue with edit after upgrading Smart Start Screen Data Inconsistencies Apr 23, 2024
@robertsLando
Copy link
Member

robertsLando commented Apr 23, 2024

PR ready for who wants to give it a try #3684

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants