Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Z-Wave JS UI 3.0.0 - dark mode no longer working #3382

Closed
2 of 3 tasks
ahahamyan opened this issue Oct 27, 2023 · 5 comments · Fixed by #3390
Closed
2 of 3 tasks

Z-Wave JS UI 3.0.0 - dark mode no longer working #3382

ahahamyan opened this issue Oct 27, 2023 · 5 comments · Fixed by #3390
Labels
bug Something isn't working

Comments

@ahahamyan
Copy link

Checklist

  • I am not using Home Assistant. Or: a developer has told me to come here.
  • I have checked the troubleshooting section and my problem is not described there.
  • I have read the changelog and my problem is not mentioned there.

Deploy method

Docker

Z-Wave JS UI version

3.0.0

ZwaveJS version

HA 2023.10.5

Describe the bug

Dark mode on UI is not working, even though set, it shows white background. When toggled on and off, it works, but then when you go back in, it is back to white background again even though dark mode toggle is on.

To Reproduce

open Zwave JS UI, and set dark mode. Go to another part of HA and then come back to zwave-js-ui and it will be back with white background even though dark mode toggle is on.

Expected behavior

When dark mode is selected, it should remain persistent until changed.

Additional context

No response

@ahahamyan ahahamyan added the bug Something isn't working label Oct 27, 2023
@nathan-curtis
Copy link

+1
a permanent Dark mode user here - 3.0.0 pops in "blind me" mode first time I open the main JS_UI screen no matter what is selected in the Settings: UI menu

Install mode: JS_UI 3.0.0 HA Addon

@robertsLando
Copy link
Member

robertsLando commented Oct 28, 2023

When you change the dark mode in settings do you press on UPDATE button? Now theme and other ui settings are stored in settings json instead of local storage so your settings can persist across different browsers

@Trblz42
Copy link

Trblz42 commented Oct 28, 2023

I have the same issue. To reproduce

  1. updated to JS_UI 3.0.0 .... now the UI is in light mode.
  2. ZwaveJS -> Settings -> UI .... Dark Mode switch shows still as Enabled
  3. Dark Mode switch on -> off .... UI is still in light mode.
  4. Dark Mode switch off -> on ..... now the UI is in dark mode
  5. Save
  6. Switch to another view
  7. Switch back to Zwave JS UI ....its back in light mode.

@nathan-curtis
Copy link

Exact same repro/workflow here @robertsLando

@robertsLando
Copy link
Member

I'm sorry for the issue guys, I will fix it ASAP 🙏🏻 in the meantime downgrade to previous version. I will try to reproduce this on my end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants