Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Node.js 15 is unsupported, migrate to next version? (Docker) #1342

Closed
4 of 7 tasks
kpine opened this issue Jun 15, 2021 · 7 comments · Fixed by #1344
Closed
4 of 7 tasks

[bug] Node.js 15 is unsupported, migrate to next version? (Docker) #1342

kpine opened this issue Jun 15, 2021 · 7 comments · Fixed by #1344
Assignees
Labels
bug Something isn't working

Comments

@kpine
Copy link
Contributor

kpine commented Jun 15, 2021

Version

Checklist:

  • I am not using HomeAssistant. Or: a developer has told me to come here.
  • I have checked the troubleshooting section and my problem is not described there.
  • I have read the changelog problem was not mentioned there.

Build/Run method

  • Docker
  • PKG
  • Snap package
  • Manually built (git clone - yarn install - yarn run build )

zwavejs2mqtt version: 5.0.1
zwave-js version: 7.7.3

Describe the bug

The official docker release uses Node.js 15.11.0. Node.js 15 became unsupported as of June 1, 2021. Would it make sense to begin migrating to 16?

Another thing I've noticed is that Dockerfile.contrib use the image node:erbium-buster, AKA Node.js 12. Would it also make sense to match this version to the same one as the official image, e.g. node:16.3.0-alpine and node:16.3.0-buster?

@kpine kpine added the bug Something isn't working label Jun 15, 2021
@robertsLando
Copy link
Member

I didn't updated the image because Dependabot PR was failing: #1305

Will see if I can make it working today

robertsLando added a commit that referenced this issue Jun 15, 2021
robertsLando added a commit that referenced this issue Jun 15, 2021
* chore(docker): bump node to 16.3.0

Fixes #1342

* fix: python build error
@kpine
Copy link
Contributor Author

kpine commented Jun 17, 2021

@robertsLando Do you have any details on what isn't working with the node:16.3.0-alpine image? I built a container using commit e86a24a and everything is working fine so far. I run it on a RPI4 with debian aarch64. I'm wondering if there's some problem I'm not noticing.

@robertsLando
Copy link
Member

robertsLando commented Jun 17, 2021

The problem is with armv7, don't know the root cause but it's related to node 16.3.0 alpine-3.13

@kpine
Copy link
Contributor Author

kpine commented Jun 17, 2021

Do you have any links you could point me to? Like I said, I am using that build with 16.3.0 alpine-3.13, and an RPi4 which is armv7.

@robertsLando
Copy link
Member

I don't have any link, I just had this report from a user on slack and after some investigation It turns out that the problem was related to that specific image, even a simply docker run of node:16.3.0-alpine3.13 got the same error.

Here a link to the comment on slack: https://zwave-js.slack.com/archives/C01DQ24SDKL/p1623921735113100

@kpine
Copy link
Contributor Author

kpine commented Jun 17, 2021

Thanks. From that I could find a lot of issues related to this, one of them being nodejs/docker-node#1477

What's odd is my system has libseccomp2 version 2.3.3-4, which is supposed to be broken, yet it's working fine. 🤷

@robertsLando
Copy link
Member

robertsLando commented Jun 18, 2021

Yeah really weird error 😕 Like almost every docker related error 🤷🏼‍♂️ When things works it's awesome when they don't it's a nightmare

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants