fix(ui): correctly display CRC errors on zniffer (#4039)

zwave-js · Dec 11, 2024 · f868b69 · f868b69
1 parent 4b446b9
commit f868b69
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/src/lib/utils.js b/src/lib/utils.js
@@ -224,6 +224,10 @@ export function getRegion(item) {
 	)
 }
 export function getRoute(item, withRssi = false) {
+	if (item.corrupted) {
+		return ''
+	}
+
 	const repRSSI = item.repeaterRSSI || []
 	const dir = item.direction === 'inbound' ? '←' : '→'
 	const hop = item.hop !== undefined ? item.hop : -1
@@ -267,6 +271,10 @@ export function getRoute(item, withRssi = false) {
 	return routeString
 }
 export function getType(item) {
+	if (item.corrupted) {
+		return ''
+	}
+
 	if (item.protocol === Protocols.ZWaveLongRange) {
 		return getEnumMemberName(LongRangeFrameType, item.type)
 	} else {

diff --git a/src/views/Zniffer.vue b/src/views/Zniffer.vue
@@ -168,7 +168,8 @@
 							<template
 								v-slot:[`item.protocolDataRate`]="{ item }"
 							>
-								<div class="d-flex text-center">
+								<span v-if="item.corrupted">----</span>
+								<div v-else class="d-flex text-center">
 									<rich-value
 										:value="getProtocolIcon(item.protocol)"
 									/>
@@ -182,7 +183,9 @@
 							</template>
 
 							<template v-slot:[`item.type`]="{ item }">
-								{{ getType(item) }}
+								<span>
+									{{ getType(item) }}
+								</span>
 							</template>
 
 							<template v-slot:[`item.sourceNodeId`]="{ item }">
@@ -194,10 +197,13 @@
 							</template>
 
 							<template v-slot:[`item.payload`]="{ item }">
+								<code v-if="item.corrupted"> CRC Error </code>
 								<span v-if="item.parsedPayload">
 									{{ getPayloadTags(item.parsedPayload) }}
 								</span>
-								<span v-else-if="item.payload">
+								<span
+									v-else-if="item.payload && !item.corrupted"
+								>
 									{{ item.payload }}
 								</span>
 								<span v-else-if="item.routedAck"