fix: prevent undefined values on refreshInfo

zwave-js · Dec 28, 2020 · efab02e · efab02e
1 parent 052a043
commit efab02e
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/lib/ZwaveClient.js b/lib/ZwaveClient.js
@@ -707,7 +707,12 @@ function parseValue (zwaveNode, zwaveValue, zwaveValueMeta) {
     zwaveValue,
     zwaveValueMeta
   )
-  valueId.value = zwaveNode.getValue(zwaveValue)
+
+  const vID = getValueID(valueId)
+
+  const prevValue = node.values[vID] ? node.values[vID].value : null
+  valueId.value =
+    zwaveValue.newValue || prevValue || zwaveNode.getValue(zwaveValue)
 
   if (isCurrentValue(valueId)) {
     valueId.isCurrentValue = true
@@ -717,7 +722,7 @@ function parseValue (zwaveNode, zwaveValue, zwaveValueMeta) {
     }
   }
 
-  node.values[getValueID(valueId)] = valueId
+  node.values[vID] = valueId
 
   return valueId
 }