feat(config): add Bulk Set Parameter to Inovelli Switches for LED Notifications #7451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanjohnsontv
changed the title
ryanjohnsontv
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new parameter to Inovelli's LZW30-SN, LZW31-SN, LZW36, and VZW31-SN devices to allow setting the LED notification/event in one parameter instead of multiple. The use case here would be easier multicast event commands that have just a calculated value for the notification/effect (ex. site for calculating this value)
I was unaware that there was a hard rule on allowing partial parameters and "parent" parameters for the same config. I do believe there are some use cases where they can coexist (I've been running this setup for over a year now without issue). If that is not within the scope of this project I understand! For sake of this PR I added a new
lintSkipconfig field that allows skipping a specific lint check for a given parameter.