feat: add Thermostat Setback mocks, fix state encoding, remove CC values #7271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zwave-js-bot automerge |
zwave-js-bot
approved these changes
Oct 10, 2024
AlCalzone
added a commit
that referenced
this pull request
Oct 10, 2024
### Features * Thermostat Setback CC: Fix encoding of the setback state, add mocks, remove non-functional CC values (#7271)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing the mocks for Thermostat Setback CC, I noticed that the CC values don't really make sense. They cannot be used to set the setback type or state, they don't have useful states, and the setback state does not expose the special values. So they are now removed.