Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support learn mode #7135

Merged
merged 23 commits into from
Sep 6, 2024
Merged

feat: support learn mode #7135

merged 23 commits into from
Sep 6, 2024

Conversation

AlCalzone
Copy link
Member

@AlCalzone AlCalzone commented Aug 29, 2024

This PR adds support for joining another network using S2 and S0 and being a secondary controller

fixes: #6428

enables #7096
enables #1070

@AlCalzone AlCalzone marked this pull request as ready for review September 6, 2024 09:41
@AlCalzone
Copy link
Member Author

@zwave-js-bot automerge

@zwave-js-bot zwave-js-bot enabled auto-merge (squash) September 6, 2024 12:15
@zwave-js-bot zwave-js-bot merged commit d6c3906 into master Sep 6, 2024
17 checks passed
@zwave-js-bot zwave-js-bot deleted the learn-mode branch September 6, 2024 12:22
AlCalzone added a commit that referenced this pull request Sep 12, 2024
### Features
* Add support for EU Long Range (#6751)
* Support learn mode to become a secondary controller (#7135)
* Add method to query supported RF regions and their info (#7118)
* Support `Firmware Update Meta Data CC` v8 (#7079)
* Implement 32-bit addressed NVM operations (#7114)
* Add methods to reset SPAN of one or all nodes (#7105)

### Bugfixes
* Fix missing values in endpoint dump (#7101)

### Config file changes
* Add new fingerprint for TZ45 thermostat (#7127)
* Add alarm mapping for Schlage lock CKPD FE599 (#7122)
* Add fingerprint for Climax Technology SDCO-1 (#7102)
* Add Shelly Wave Pro 3 and Wave Pro Shutter (#7103)
* Remove endpoint workaround for Zooz ZEN30, FW 3.20+ (#7115)

### Changes under the hood
* Document soft-reset issue in VMs (#7119)
* Update documentation for troubleshooting and Zniffer, clean up migration guides (#7107)
* Update `FunctionType` definitions (#7106)
* CI now checks that all device config files have a `.json` extension (#7099)
AlCalzone added a commit that referenced this pull request Sep 20, 2024
zwave-js-bot pushed a commit that referenced this pull request Sep 20, 2024
@iskiselev
Copy link

iskiselev commented Sep 25, 2024

Should FAQ be also updated now? https://github.com/zwave-js/node-zwave-js/blob/master/docs/getting-started/faq.md or is it still considered "Not supported"?

@AlCalzone
Copy link
Member Author

It's not fully supported yet - the other half of the Inclusion Controller CC implementation is missing. But I guess it's good enough to update the FAQ.

@brandond
Copy link

Does this mean I can run a second instance of zwave-js-ui elsewhere in my environment, with another stick. and join it to the network as a range extender? It's not clear from the docs how to get it to join an existing network on startup.

@AlCalzone
Copy link
Member Author

No, a secondary controller does not have the same functionality as the primary. For example with some devices you can not have them report to more than one controller.

What you may be thinking of (multiple instances cooperating) would require some backend work. It may come one day, but no guarantees.

@brandond
Copy link

Right but even if I didn't want to have it report to the secondary controller, or do any management from that node, could I at least get it as far as joining the network to extend the range of the mesh? I'm confused as to what the current limited support actually allows for.

@AlCalzone
Copy link
Member Author

I don't think there's support for this in Z-Wave JS UI yet.

I'm confused as to what the current limited support actually allows for.

Mainly in preparation for #7096

/cc @robertsLando

@robertsLando
Copy link
Member

No support in UI yet but you could still try using it with driver function

@brandond
Copy link

Do you have any pointers on how to do that? I'm assuming I'd need to run the driver headless and pass it the keys and such?

@robertsLando
Copy link
Member

@brandond Never tried those new APIs so I have no clue but if you want to understand how to work with custom driver functions you can look at docs here: https://zwave-js.github.io/zwave-js-ui/#/usage/driver_function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Learn Mode to become a secondary controller
5 participants