Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): add Ring Alarm Panic Button Gen2 #6453

Merged
merged 2 commits into from
Oct 24, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 71 additions & 0 deletions packages/config/config/devices/0x0346/panic_button_gen2.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
{
"manufacturer": "Ring",
"manufacturerId": "0x0346",
"label": "Ring Alarm Panic Button",
"description": "Panic Button (2nd Gen)",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will cause some applications to display the device as

Ring Ring Alarm Panic Button Panic Button (2nd Gen)

Do you know the model number by any chance, e.g. like on the contact sensor:

	"manufacturer": "Ring",
	"manufacturerId": "0x0346",
	"label": "4SD2SZ-0EN0",
	"description": "Contact Sensor Gen2",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll ask.

"devices": [
{
"productType": "0x0801",
"productId": "0x0401"
}
],
"firmwareVersion": {
"min": "0.0",
"max": "255.255"
},
"paramInformation": [
{
"#": "1",
"label": "Heartbeats",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"label": "Heartbeats",
"label": "Heartbeat Interval",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

"valueSize": 1,
"unit": "minutes",
"minValue": 1,
"maxValue": 70,
"defaultValue": 70
},
{
"#": "2",
"label": "Number of Application Level Retries",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"label": "Number of Application Level Retries",
"label": "Message Retry Attempt Limit",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

"valueSize": 1,
"minValue": 0,
"maxValue": 5,
"defaultValue": 1
},
{
"#": "3",
"label": "Application Level Retry Base Wait Time Period",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"label": "Application Level Retry Base Wait Time Period",
"label": "Delay Between Retry Attempts",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

"valueSize": 1,
"unit": "seconds",
"minValue": 1,
"maxValue": 60,
"defaultValue": 5
},
{
"#": "4",
"label": "Button Hold-Time",
"valueSize": 1,
"unit": "0.5 seconds",
"minValue": 1,
"maxValue": 20,
"defaultValue": 6
},
{
"#": "5",
"label": "Wait Time for A Supervisory Report Response",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"label": "Wait Time for A Supervisory Report Response",
"label": "Supervision Report Timeout",
"description": "How long to wait for a Supervision Report response to a Supervision Get",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done FYI- I picked up these labels from the Gen 1 Ring Panic button on the zwa website. Deleted the model number and meta data because device wasn't a match and could cause confusion.

"valueSize": 2,
"unit": "ms",
"minValue": 500,
"maxValue": 30000,
"defaultValue": 10000
},
{
"#": "6",
"label": "One Shot Timer",
"valueSize": 2,
"unit": "seconds",
"minValue": 500,
"maxValue": 30000,
"defaultValue": 10000
}
]
}