fix: discard Meter CC and Multilevel Sensor CC reports when the node does not support them
#6178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zwave-js-bot automerge |
zwave-js-bot
approved these changes
Aug 17, 2023
AlCalzone
added a commit
that referenced
this pull request
Aug 22, 2023
### Features * Auto-detected serialports now prominently include `/dev/serial/by-id/*` paths (#6182) ### Bugfixes * Discard `Meter CC` and `Multilevel Sensor CC` reports when the node they supposedly come from does not support them (#6178) * Abort inclusion when a node with the same ID is already part of the network (#6180) * Fixed an issue where a node that does not support S0 and/or S2 was shown with an unknown security class (#6187) * Fixed a regression from `v11.12.0` where devices with a `proprietary` field in the device config would not finish the interview (#6202) ### Config file changes * Remove unnecessary endpoint functionality for CT100 (#6185) ### Changes under the hood * Extended documentation for parsing QR codes (#6181) * Fixed an issue where directly editing `driver.options` in tests would modify the `defaultOptions` and influence future driver instances (#6188)
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR helps with situations where reports get corrupted on air and get attributed to a different node ID. We may consider expanding this check to all CCs, but this will likely result in breaks for some users where devices don't report all their capabilities.
fixes: #5510