Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): correct lifeline association and param 3 for ZWN-RSM2-PLUS #4046

Merged
merged 3 commits into from
Jan 10, 2022
Merged

fix(config): correct lifeline association and param 3 for ZWN-RSM2-PLUS #4046

merged 3 commits into from
Jan 10, 2022

Conversation

ronytomen
Copy link
Contributor

Fixes: #2280

  • Force Endpoint 0 for Group 1 Associations Lifeline so that CurrentValue
    status reports are sent and processed.
  • Define the one configuration parameters options as per mfg data

Did some experimentation to get this device to report manual local change (someone turns the switch off or on) and found that setting the Endpoint Target to 0 for Group 1 Association (Lifeline) did the trick. I only found one other example of Endpoint usage in device configurations, so I hope I got this correct.

- Force Endpoint 0 for Group 1 Associations Lifeline so that CurrentValue
  status reports are sent and processed.
- Define the one configuration parameters options as per mfg data
@zwave-js-assistant zwave-js-assistant bot added the config ⚙ Configuration issues or updates label Jan 5, 2022
@ronytomen
Copy link
Contributor Author

Screen Shot 2022-01-05 at 4 32 53 PM

For the record, attached screenshot of working group association with endpoint target.

@AlCalzone
Copy link
Member

I think the documentation of that config setting isn't up to date. You should be able to achieve the same result by setting "multiChannel": true on the first association group without dabbling with endpoint associations.

Copy link
Member

@AlCalzone AlCalzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try the suggestion, re-interview your device and post a driver log of that. I'm fine with keeping it this way if it won't work, but ideally it should.

@ronytomen
Copy link
Contributor Author

I think the documentation of that config setting isn't up to date. You should be able to achieve the same result by setting "multiChannel": true on the first association group without dabbling with endpoint associations.

Thank you! I was trying to figure this out, but decided to post the PR for some sage advise. I will revise, test and update in the next few days.

@ronytomen
Copy link
Contributor Author

ronytomen commented Jan 9, 2022

Attached is the Interview log for node 38 with the suggested change in place.

node_38.log

@AlCalzone
Copy link
Member

Looks OK, does it work for you?

@AlCalzone AlCalzone changed the title fix(config): ZWN-RSM2-PLUS #2280 fix(config): correct lifeline association and param 3 for ZWN-RSM2-PLUS Jan 9, 2022
@ronytomen
Copy link
Contributor Author

Just did some more testing.

  1. Cleared the current associations
  2. Re-interviewed

No group associations were created and the configuration parameter does not show up.
Screen Shot 2022-01-09 at 11 35 37 AM
Screen Shot 2022-01-09 at 11 35 15 AM

It is using the modified device configuration, debug for node 38 attached.
node_38_debug.txt

@AlCalzone
Copy link
Member

Weird, your log did show an existing multi channel association

@ronytomen
Copy link
Contributor Author

I don't think that interview had the associations removed. Let me get the interview with the associations removed before starting.

@ronytomen
Copy link
Contributor Author

ronytomen commented Jan 9, 2022

I wanted to note that either the Lifeline or per switch association works, but only if Target Endpoint 0 is specified. Otherwise the status of each of the switches does not update.

lifeline_association_working

switch_association_working

@ronytomen
Copy link
Contributor Author

Here is the log for Node 38 Interview with associations cleared. Result, no associations created.
node_38_interview_20210109_1.log

@AlCalzone
Copy link
Member

AlCalzone commented Jan 9, 2022

Heh, the device claims it supports Multi Channel Association V2. However, being able to use 0 as the target endpoint was only added in V3 of that CC, so the driver won't do it.

We need to overwrite the reported version aswell, please add that to your config file (before metadata):

"compat": {
	"commandClasses": {
		"add": {
			// The device needs a multi channel lifeline association (target endpoint 0),
			// but only reports support for V2, which doesn't allow this.
			"0x8e": {
				"version": 3
			}
		}
	}
}

@ronytomen
Copy link
Contributor Author

Updated device file and tested. Works as expected creating the correct Lifeline Association with a EndPoint Target 0.

😀

@AlCalzone AlCalzone merged commit 7af5dc9 into zwave-js:master Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config ⚙ Configuration issues or updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect device config for ZWN-RSM2-PLUS
3 participants